* [PATCH] ALSA: doc: my_chip has no element ioport
@ 2019-04-02 12:16 Christina Quast
2019-04-03 9:56 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Christina Quast @ 2019-04-02 12:16 UTC (permalink / raw)
Cc: trivial, Christina Quast, Jaroslav Kysela, Takashi Iwai,
Jonathan Corbet, Takashi Sakamoto, alsa-devel, linux-doc,
linux-kernel
chip->ioport is dereferenced in two places, but the struct is
defined as follows:
struct mychip {
struct snd_card *card;
struct pci_dev *pci;
unsigned long port;
int irq;
};
Signed-off-by: Christina Quast <cquast@hanoverdisplays.com>
---
Documentation/sound/kernel-api/writing-an-alsa-driver.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/sound/kernel-api/writing-an-alsa-driver.rst b/Documentation/sound/kernel-api/writing-an-alsa-driver.rst
index 6b154dbb02cc..132f5eb9b530 100644
--- a/Documentation/sound/kernel-api/writing-an-alsa-driver.rst
+++ b/Documentation/sound/kernel-api/writing-an-alsa-driver.rst
@@ -324,7 +324,7 @@ to details explained in the following section.
strcpy(card->driver, "My Chip");
strcpy(card->shortname, "My Own Chip 123");
sprintf(card->longname, "%s at 0x%lx irq %i",
- card->shortname, chip->ioport, chip->irq);
+ card->shortname, chip->port, chip->irq);
/* (5) */
.... /* implemented later */
@@ -437,7 +437,7 @@ Since each component can be properly freed, the single
strcpy(card->driver, "My Chip");
strcpy(card->shortname, "My Own Chip 123");
sprintf(card->longname, "%s at 0x%lx irq %i",
- card->shortname, chip->ioport, chip->irq);
+ card->shortname, chip->port, chip->irq);
The driver field holds the minimal ID string of the chip. This is used
by alsa-lib's configurator, so keep it simple but unique. Even the
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: doc: my_chip has no element ioport
2019-04-02 12:16 [PATCH] ALSA: doc: my_chip has no element ioport Christina Quast
@ 2019-04-03 9:56 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2019-04-03 9:56 UTC (permalink / raw)
To: Christina Quast
Cc: alsa-devel, trivial, Jonathan Corbet, Jaroslav Kysela,
Takashi Sakamoto, linux-doc, linux-kernel
On Tue, 02 Apr 2019 14:16:48 +0200,
Christina Quast wrote:
>
> chip->ioport is dereferenced in two places, but the struct is
> defined as follows:
>
> struct mychip {
> struct snd_card *card;
> struct pci_dev *pci;
>
> unsigned long port;
> int irq;
> };
>
> Signed-off-by: Christina Quast <cquast@hanoverdisplays.com>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-03 9:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-02 12:16 [PATCH] ALSA: doc: my_chip has no element ioport Christina Quast
2019-04-03 9:56 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome