mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: perex@perex.cz, yongjun_wei@trendmicro.com.cn,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: use list_move_tail instead of list_del/list_add_tail
Date: Wed, 05 Sep 2012 09:40:45 +0200	[thread overview]
Message-ID: <s5h7gs8kjcy.wl%tiwai@suse.de> (raw)
In-Reply-To: <CAPgLHd8KyjsepcaW4zffjQG4ma4sdzmTa6wafwWh55La7qWzMQ@mail.gmail.com>

At Wed, 5 Sep 2012 15:00:15 +0800,
Wei Yongjun wrote:
> 
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> Using list_move_tail() instead of list_del() + list_add_tail().
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Applied this one, too.  Thanks.


Takashi


> ---
>  sound/pci/emu10k1/memory.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/pci/emu10k1/memory.c b/sound/pci/emu10k1/memory.c
> index 0a43662..1dce0a39 100644
> --- a/sound/pci/emu10k1/memory.c
> +++ b/sound/pci/emu10k1/memory.c
> @@ -263,8 +263,8 @@ int snd_emu10k1_memblk_map(struct snd_emu10k1 *emu, struct snd_emu10k1_memblk *b
>  	spin_lock_irqsave(&emu->memblk_lock, flags);
>  	if (blk->mapped_page >= 0) {
>  		/* update order link */
> -		list_del(&blk->mapped_order_link);
> -		list_add_tail(&blk->mapped_order_link, &emu->mapped_order_link_head);
> +		list_move_tail(&blk->mapped_order_link,
> +			       &emu->mapped_order_link_head);
>  		spin_unlock_irqrestore(&emu->memblk_lock, flags);
>  		return 0;
>  	}
> 
> 

  reply	other threads:[~2012-09-05  7:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-05  7:00 Wei Yongjun
2012-09-05  7:40 ` Takashi Iwai [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-09-05  6:33 Wei Yongjun
2012-09-05  7:06 ` Clemens Ladisch
2012-09-05  7:40 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h7gs8kjcy.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=weiyj.lk@gmail.com \
    --cc=yongjun_wei@trendmicro.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®