mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Guido Trentalancia <guido@trentalancia.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] snd_hda_codec_realtek: enable ALC271 for Acer laptops
Date: Thu, 14 Apr 2011 21:26:23 +0200	[thread overview]
Message-ID: <s5h7hawd480.wl%tiwai@suse.de> (raw)
In-Reply-To: <1302800932.2766.42.camel@vortex>

At Thu, 14 Apr 2011 19:08:47 +0200,
Guido Trentalancia wrote:
> 
> Hello again Takashi.
> 
> On Thu, 2011-04-14 at 11:45 +0200, Takashi Iwai wrote:
> > At Thu, 07 Apr 2011 19:38:27 +0200,
> > Guido Trentalancia wrote:
> > > 
> > > This quick fix to the Realtek HD Audio driver enables configurable support for the ALC271 type commonly found on some Acer laptops (e.g. Aspire 5745G).
> > > 
> > > Normally, the driver would fall back to BIOS auto-probing. However, the "model=acer" parameter can be passed on the boot command line to enable such support. Otherwise, it is quite common that the internal microphone does not work.
> > 
> [cut]
> > 
> > Anyway, it's not such quite common that the machine doesn't work
> > without the model quirk any longer :)  In most cases, we want to avoid
> > the model quirk but fixing the pin configuration instead.
> 
> Actually I have to disagree on the "not quite common". Just use the
> right keywords (including "microphone") along with a good web search
> engine and you'll discover plenty of reports for this chipset including
> formal bug reports on several distributions.

You missed the point.  What's not common is that you MUST give the
model quirk to resolve the problem.  In most cases, it's just a wrongly
set pin configuration, or a parser bug.  For both of which, the proper
solution is not to pass or create a model quirk.

Looking for bugs by google easy.  But looking for bug fixes without
proper information isn't easy.


Takashi

      reply	other threads:[~2011-04-14 19:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-07 17:38 Guido Trentalancia
2011-04-14  9:45 ` Takashi Iwai
2011-04-14 16:59   ` Guido Trentalancia
2011-04-14 19:29     ` Takashi Iwai
2011-04-14 17:08   ` Guido Trentalancia
2011-04-14 19:26     ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h7hawd480.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=guido@trentalancia.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®