From: Takashi Iwai <tiwai@suse.de>
To: "Guido Trentalancia" <guido@trentalancia.com>
Cc: linux-kernel@vger.kernel.org, kailang@realtek.com.tw,
pshou@realtek.com.tw, jwoithe@physics.adelaide.edu.au
Subject: Re: [PATCH] snd_hda_codec_realtek: enable ALC271 for Acer laptops
Date: Thu, 14 Apr 2011 11:45:13 +0200 [thread overview]
Message-ID: <s5haaftmaja.wl%tiwai@suse.de> (raw)
In-Reply-To: <201104071738.p37HcSFX019185@vivaldi20.register.it>
At Thu, 07 Apr 2011 19:38:27 +0200,
Guido Trentalancia wrote:
>
> This quick fix to the Realtek HD Audio driver enables configurable support for the ALC271 type commonly found on some Acer laptops (e.g. Aspire 5745G).
>
> Normally, the driver would fall back to BIOS auto-probing. However, the "model=acer" parameter can be passed on the boot command line to enable such support. Otherwise, it is quite common that the internal microphone does not work.
Well, adding the quirk label is fine, but this is no real fix.
I can apply it with a different subject.
Anyway, it's not such quite common that the machine doesn't work
without the model quirk any longer :) In most cases, we want to avoid
the model quirk but fixing the pin configuration instead.
If the auto-parser doesn't work as is, please give alsa-info.sh output
on your machine, and give the exact description what doesn't actually
work. Then we can fix in a better way.
thanks,
Takashi
> --- linux-2.6.38.2-original/sound/pci/hda/patch_realtek.c 2011-04-07 17:56:25.053046707 +0200
> +++ linux-2.6.38.2/sound/pci/hda/patch_realtek.c 2011-04-07 19:03:00.975706888 +0200
> @@ -15028,6 +15028,7 @@ static const char * const alc269_models[
> [ALC269_DMIC] = "laptop-dmic",
> [ALC269_FUJITSU] = "fujitsu",
> [ALC269_LIFEBOOK] = "lifebook",
> + [ALC271_ACER] = "acer",
> [ALC269_AUTO] = "auto",
> };
>
>
next prev parent reply other threads:[~2011-04-14 9:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-07 17:38 Guido Trentalancia
2011-04-14 9:45 ` Takashi Iwai [this message]
2011-04-14 16:59 ` Guido Trentalancia
2011-04-14 19:29 ` Takashi Iwai
2011-04-14 17:08 ` Guido Trentalancia
2011-04-14 19:26 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5haaftmaja.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=guido@trentalancia.com \
--cc=jwoithe@physics.adelaide.edu.au \
--cc=kailang@realtek.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=pshou@realtek.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®