From: Takashi Iwai <tiwai@suse.de>
To: xiphmont@xiph.org
Cc: "Pierre Ossman" <drzeus@drzeus.cx>,
fedora-desktop-list@redhat.com, alsa-devel@alsa-project.org,
jrb@redhat.com, "Greg KH" <greg@kroah.com>,
linux-kernel@vger.kernel.org, mclasen@redhat.com,
"Lennart Poettering" <lennart@poettering.net>,
perex@suse.cz
Subject: Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks
Date: Thu, 25 Jan 2007 18:47:26 +0100 [thread overview]
Message-ID: <s5h7ivbuhg1.wl%tiwai@suse.de> (raw)
In-Reply-To: <806dafc20701250930n185e9773i64bbd2d845c836be@mail.gmail.com>
At Thu, 25 Jan 2007 12:30:44 -0500,
xiphmont@xiph.org wrote:
>
> > I'm working on this now and will doublecheck just in case my test was
> > flawed first time.
>
> Doublechecking indicates my initial test was wrong somehow; both
> card->dev->parent and card->parent passed as arg 2 to the
> device_create call in snd_register_device result in correct device
> symlinks. Are these two actually semantically different? I'm just
> curious.
If card->dev is created, they should be identical.
But, again, card->dev should be NULL on the older systems.
> The call to device_create in cound_core.c:sound_insert_unit also needs
> to be modified in order for the device symlinks in the other unit
> types to be correct. Again, modifying the 'dev' argument to
> '(dev?dev->parent:NULL)' appears to fix the problem. Is that
> correct/appropriate there?
Your change breaks the expected heavior if CONFIG_SYSFS_DEPRECATED is
enabled. Then devices won't belong to card* objects any more...
Takashi
next prev parent reply other threads:[~2007-01-25 17:47 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-25 1:50 Christopher "Monty" Montgomery
2007-01-25 4:26 ` Greg KH
2007-01-25 14:11 ` Christopher "Monty" Montgomery
2007-01-25 15:15 ` Pierre Ossman
2007-01-25 15:36 ` Christopher "Monty" Montgomery
2007-01-25 15:40 ` Pierre Ossman
2007-01-25 15:57 ` Christopher "Monty" Montgomery
2007-01-25 16:54 ` [Alsa-devel] " Takashi Iwai
2007-01-25 17:03 ` Christopher "Monty" Montgomery
2007-01-25 17:30 ` xiphmont
2007-01-25 17:47 ` Takashi Iwai [this message]
2007-01-25 18:07 ` xiphmont
2007-01-25 18:23 ` Takashi Iwai
2007-01-25 18:34 ` xiphmont
2007-01-25 18:38 ` Takashi Iwai
2007-01-25 18:51 ` xiphmont
2007-01-25 19:49 ` Greg KH
2007-01-25 20:40 ` xiphmont
2007-01-25 21:59 ` Greg KH
2007-01-26 10:53 ` xiphmont
2007-01-26 11:40 ` Takashi Iwai
2007-01-26 18:04 ` Greg KH
2007-01-26 18:25 ` Takashi Iwai
2007-01-26 18:31 ` xiphmont
2007-01-26 19:06 ` Greg KH
2007-01-26 21:58 ` xiphmont
2007-01-26 18:03 ` xiphmont
2007-01-26 18:42 ` Greg KH
2007-01-25 17:48 ` Christopher "Monty" Montgomery
2007-01-25 11:27 ` Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h7ivbuhg1.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=drzeus@drzeus.cx \
--cc=fedora-desktop-list@redhat.com \
--cc=greg@kroah.com \
--cc=jrb@redhat.com \
--cc=lennart@poettering.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mclasen@redhat.com \
--cc=perex@suse.cz \
--cc=xiphmont@xiph.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®