mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Dave Jones <davej@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: fix usbmixer double kfree.
Date: Tue, 07 Mar 2006 12:13:45 +0100	[thread overview]
Message-ID: <s5h7j76tsly.wl%tiwai@suse.de> (raw)
In-Reply-To: <20060306164111.5510fc09.akpm@osdl.org>

At Mon, 6 Mar 2006 16:41:11 -0800,
Andrew Morton wrote:
> 
> Dave Jones <davej@redhat.com> wrote:
> >
> > snd_ctl_add() kfree's the kcontrol already if we fail there,
> > so this driver is currently doing a double kfree.
> 
> Well sometimes it does.  If we hit one of those snd_assert() abominations,
> snd_ctl_add() will return error without freeing the kcontrol.

Indeed.  I'll fix them later.

> Still, a leak is better than a double-free.

Yep :)


thanks,

Takashi

      reply	other threads:[~2006-03-07 11:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-06  8:49 Dave Jones
2006-03-06 13:43 ` Takashi Iwai
2006-03-07  0:41 ` Andrew Morton
2006-03-07 11:13   ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h7j76tsly.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=akpm@osdl.org \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®