mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Dave Jones <davej@redhat.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: fix usbmixer double kfree.
Date: Mon, 06 Mar 2006 14:43:10 +0100	[thread overview]
Message-ID: <s5hek1fn0y9.wl%tiwai@suse.de> (raw)
In-Reply-To: <20060306084951.GA15905@redhat.com>

At Mon, 6 Mar 2006 03:49:51 -0500,
Dave Jones wrote:
> 
> snd_ctl_add() kfree's the kcontrol already if we fail there,
> so this driver is currently doing a double kfree.
> 
> Coverity bug #959
> 
> Signed-off-by: Dave Jones <davej@redhat.com>
>
> --- linux-2.6/sound/usb/usbmixer.c~	2006-03-06 03:40:20.000000000 -0500
> +++ linux-2.6/sound/usb/usbmixer.c	2006-03-06 03:45:03.000000000 -0500
> @@ -434,7 +434,6 @@ static int add_control_to_empty(struct m
>  		kctl->id.index++;
>  	if ((err = snd_ctl_add(state->chip->card, kctl)) < 0) {
>  		snd_printd(KERN_ERR "cannot add control (err = %d)\n", err);
> -		snd_ctl_free_one(kctl);
>  		return err;
>  	}
>  	cval->elem_id = &kctl->id;
> 


Thanks, applied to ALSA tree now, too.

Signed-off-by: Takashi Iwai <tiwai@suse.de>


Takashi

  reply	other threads:[~2006-03-06 13:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-06  8:49 Dave Jones
2006-03-06 13:43 ` Takashi Iwai [this message]
2006-03-07  0:41 ` Andrew Morton
2006-03-07 11:13   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hek1fn0y9.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®