From: Takashi Iwai <tiwai@suse.de>
To: "Colin King" <colin.king@canonical.com>
Cc: <alsa-devel@alsa-project.org>,
"Arvind Yadav" <arvind.yadav.cs@gmail.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Sakamoto" <o-takashi@sakamocchi.jp>,
<kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] echoaudio: remove redundant initialization of pointer 'pipe'
Date: Mon, 12 Mar 2018 16:06:58 +0100 [thread overview]
Message-ID: <s5h8tax49kd.wl-tiwai@suse.de> (raw)
In-Reply-To: <20180312150100.8089-1-colin.king@canonical.com>
On Mon, 12 Mar 2018 16:01:00 +0100,
Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer 'pipe' is being initialized with a value that is never
> read and it is re-assigned later, hence the initialization is redundant
> and can be removed. Also remove pointer 'runtime' as it is no longer
> required.
>
> Cleans up clang warning:
> sound/pci/echoaudio/echoaudio.c:740:20: warning: Value stored to 'pipe'
> during its initialization is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
Takashi
prev parent reply other threads:[~2018-03-12 15:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 15:01 Colin King
2018-03-12 15:06 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h8tax49kd.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=arvind.yadav.cs@gmail.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=o-takashi@sakamocchi.jp \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®