mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	Jaroslav Kysela <perex@perex.cz>,
	linuxppc-dev@lists.ozlabs.org (open list:AOA (Apple Onboard
	Audio) ALSA DRIVER),
	alsa-devel@alsa-project.org (moderated list:AOA (Apple Onboard
	Audio) ALSA DRIVER), linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH] ALSA: aoa: Drop owner assignment from i2c_driver
Date: Fri, 10 Jul 2015 09:54:58 +0200	[thread overview]
Message-ID: <s5h8uaofnvx.wl-tiwai@suse.de> (raw)
In-Reply-To: <1436510344-5889-1-git-send-email-k.kozlowski@samsung.com>

On Fri, 10 Jul 2015 08:39:02 +0200,
Krzysztof Kozlowski wrote:
> 
> i2c_driver does not need to set an owner because i2c_register_driver()
> will set it.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Applied, thanks.


Takashi

> 
> ---
> 
> The coccinelle script which generated the patch was sent here:
> http://www.spinics.net/lists/kernel/msg2029903.html
> ---
>  sound/aoa/codecs/onyx.c | 1 -
>  sound/aoa/codecs/tas.c  | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/sound/aoa/codecs/onyx.c b/sound/aoa/codecs/onyx.c
> index 23c371ecfb6b..a04edff8b729 100644
> --- a/sound/aoa/codecs/onyx.c
> +++ b/sound/aoa/codecs/onyx.c
> @@ -1050,7 +1050,6 @@ MODULE_DEVICE_TABLE(i2c,onyx_i2c_id);
>  static struct i2c_driver onyx_driver = {
>  	.driver = {
>  		.name = "aoa_codec_onyx",
> -		.owner = THIS_MODULE,
>  	},
>  	.probe = onyx_i2c_probe,
>  	.remove = onyx_i2c_remove,
> diff --git a/sound/aoa/codecs/tas.c b/sound/aoa/codecs/tas.c
> index 364c7c4416e8..78ed1ffbf786 100644
> --- a/sound/aoa/codecs/tas.c
> +++ b/sound/aoa/codecs/tas.c
> @@ -939,7 +939,6 @@ MODULE_DEVICE_TABLE(i2c,tas_i2c_id);
>  static struct i2c_driver tas_driver = {
>  	.driver = {
>  		.name = "aoa_codec_tas",
> -		.owner = THIS_MODULE,
>  	},
>  	.probe = tas_i2c_probe,
>  	.remove = tas_i2c_remove,
> -- 
> 1.9.1
> 

      reply	other threads:[~2015-07-10  7:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-10  6:39 Krzysztof Kozlowski
2015-07-10  7:54 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h8uaofnvx.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=johannes@sipsolutions.net \
    --cc=k.kozlowski@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®