mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Darren Salt <linux@youmustbejoking.demon.co.uk>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.31-rc2] Missing volume controls for Intel HDA (ALC269/EeePC)
Date: Wed, 08 Jul 2009 16:39:36 +0200	[thread overview]
Message-ID: <s5h8wizqlw7.wl%tiwai@suse.de> (raw)
In-Reply-To: <507D1B5CC4%linux@youmustbejoking.demon.co.uk>

At Wed, 08 Jul 2009 15:29:49 +0100,
Darren Salt wrote:
> 
> There is a regression, introduced in aa202455eec51699e44f658530728162cefa1307
> (in alsa-kernel) which I noticed when trying to use the headphone socket on
> my EeeCPC 901: the output was *very* quiet, practically silent.
> 
> This patch corrects the control types to that which was obviously intended in
> the referenced commit.
> 
> Signed-Off-By: Darren Salt <linux@youmustbejoking.demon.co.uk>

Bah, looks like a wrong version was merged to the tree.
Applied now.  Thanks for a quick fix!


Takashi

> --- a/sound/pci/hda/patch_realtek.c	2009-07-05 17:30:41.000000000 +0100
> +++ b/sound/pci/hda/patch_realtek.c	2009-07-08 14:50:38.000000000 +0100
> @@ -12878,9 +12878,9 @@
>  
>  static struct snd_kcontrol_new alc269_eeepc_mixer[] = {
>  	HDA_CODEC_MUTE("Speaker Playback Switch", 0x14, 0x0, HDA_OUTPUT),
> -	HDA_CODEC_MUTE("Speaker Playback Volume", 0x02, 0x0, HDA_OUTPUT),
> +	HDA_CODEC_VOLUME("Speaker Playback Volume", 0x02, 0x0, HDA_OUTPUT),
>  	HDA_CODEC_MUTE("Headphone Playback Switch", 0x15, 0x0, HDA_OUTPUT),
> -	HDA_CODEC_MUTE("Headphone Playback Volume", 0x03, 0x0, HDA_OUTPUT),
> +	HDA_CODEC_VOLUME("Headphone Playback Volume", 0x03, 0x0, HDA_OUTPUT),
>  	{ } /* end */
>  };
>  
> 
> -- 
> | Darren Salt            | linux at youmustbejoking | nr. Ashington, | Doon
> | using Debian GNU/Linux | or ds    ,demon,co,uk    | Northumberland | Army
> |   <URL:http://www.youmustbejoking.demon.co.uk/progs.packages.html>
> 
> I have one illusion, and that's that I have no illusions.
> 

      reply	other threads:[~2009-07-08 14:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-08 14:29 Darren Salt
2009-07-08 14:39 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h8wizqlw7.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@youmustbejoking.demon.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®