From: Takashi Iwai <tiwai@suse.de>
To: Michal Marek <mmarek@suse.cz>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH] ALSA: clean up the logic for building sequencer modules
Date: Fri, 29 May 2009 11:53:25 +0200 [thread overview]
Message-ID: <s5h8wkgw7ze.wl%tiwai@suse.de> (raw)
In-Reply-To: <s5hprdu1c6f.wl%tiwai@suse.de>
At Wed, 27 May 2009 23:14:00 +0200,
I wrote:
>
> At Tue, 26 May 2009 17:07:52 +0200,
> Michal Marek wrote:
> >
> > Instead of mangling the CONFIG_* variables in the makefiles over and
> > over, set a few helper variables in Kconfig.
> >
> > Signed-off-by: Michal Marek <mmarek@suse.cz>
>
> Thanks for the patch.
>
> Well, I've been thinking of clean-up of these, but my idea was to
> define rather a symbol for each possible module instead of the
> intermediate defines as your patch. That is, selecting the component
> from the driver side, e.g. select SND_EMU10K1_SYNTH, SND_SEQ_MIDI_EVENT,
> etc from SND_EMU10K1 config.
>
> But, achieving it with the current kconfig seems complex, so I stopped
> it once after a bad result.
>
> I'll reconsider whether it's possible, and will apply your patch if
> it's hard / impossible :)
As I see no easy way to achieve it, I applied your patch now.
Thanks!
Takashi
prev parent reply other threads:[~2009-05-29 9:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-26 15:07 Michal Marek
2009-05-27 21:14 ` [alsa-devel] " Takashi Iwai
2009-05-29 9:53 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h8wkgw7ze.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®