From: Takashi Iwai <tiwai@suse.de>
To: Gabriel Devenyi <ace@staticwave.ca>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@lists.osdl.org
Subject: Re: [PATCH] sound/ buildcheck fixes
Date: Mon, 15 Aug 2005 12:53:38 +0200 [thread overview]
Message-ID: <s5h8xz34gjx.wl%tiwai@suse.de> (raw)
In-Reply-To: <200508142023.14439.ace@staticwave.ca>
At Sun, 14 Aug 2005 20:23:14 -0400,
Gabriel Devenyi wrote:
>
> This applies to linus' current git tree and fixes the following "make buildcheck" errors.
Hmm, I don't think all of the patch is correct. Most of replacements
__init -> __devinit looks invalid to me, e.g.
> diff --git a/sound/arm/aaci.c b/sound/arm/aaci.c
> --- a/sound/arm/aaci.c
> +++ b/sound/arm/aaci.c
> @@ -951,7 +951,7 @@ static struct amba_driver aaci_driver =
> .id_table = aaci_ids,
> };
>
> -static int __init aaci_init(void)
> +static int __devinit aaci_init(void)
> {
> return amba_driver_register(&aaci_driver);
> }
Takashi
prev parent reply other threads:[~2005-08-15 10:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-15 0:23 Gabriel Devenyi
2005-08-15 10:31 ` Jiri Slaby
2005-08-15 10:53 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h8xz34gjx.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=ace@staticwave.ca \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®