mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Christian Lachner <gladiac@gmail.com>
Cc: perex@perex.cz, tiwai@suse.com, kailang@realtek.com,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] ALSA: hda/realtek - Fix silent output on Gigabyte X570  Aorus Master after reboot from Windows
Date: Mon, 03 Jan 2022 15:19:56 +0100	[thread overview]
Message-ID: <s5ha6gcnboz.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220103140517.30273-2-gladiac@gmail.com>

On Mon, 03 Jan 2022 15:05:17 +0100,
Christian Lachner wrote:
> 
> This patch addresses an issue where after rebooting from Windows into Linux
> there would be no audio output.
> 
> It turns out that the Realtek Audio driver on Windows changes some coeffs
> which are not being reset/reinitialized when rebooting the machine. As a
> result, there is no audio output until these coeffs are being reset to
> their initial state. This patch takes care of that by setting known-good
> (initial) values to the coeffs.
> 
> We initially relied upon alc1220_fixup_clevo_p950() to fix some pins in the
> connection list. However, it also sets coef 0x7 which does not need to be
> touched. Furthermore, to prevent mixing device-specific quirks I introduced
> a new alc1220_fixup_gb_x570() which is heavily based on
> alc1220_fixup_clevo_p950() but does not set coeff 0x7 and fixes the coeffs
> that are actually needed instead.
> 
> This new alc1220_fixup_gb_x570() is believed to also work for other boards,
> like the Gigabyte X570 Aorus Extreme and the newer Gigabyte Aorus X570S
> Master. However, as there is no way for me to test these I initially only
> enable this new behaviour for the mainboard I have which is the Gigabyte
> X570(non-S) Aorus Master.
> 
> I tested this patch on the 5.15 branch as well as on master and it is
> working well for me.
> 
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=205275
> Signed-off-by: Christian Lachner <gladiac@gmail.com>

Thanks, applied now (with Cc-to-stable and Fixes tag).


Takashi

      reply	other threads:[~2022-01-03 14:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-03 14:05 [PATCH v2 0/1] " Christian Lachner
2022-01-03 14:05 ` [PATCH v2 1/1] " Christian Lachner
2022-01-03 14:19   ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5ha6gcnboz.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=gladiac@gmail.com \
    --cc=kailang@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®