From: Takashi Iwai <tiwai@suse.de>
To: "Julia Lawall" <Julia.Lawall@lip6.fr>
Cc: "Jaroslav Kysela" <perex@perex.cz>, <alsa-devel@alsa-project.org>,
<kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: atiixp: constify atiixp_dma_ops structures
Date: Wed, 30 Dec 2015 22:50:52 +0100 [thread overview]
Message-ID: <s5ha8ortxkz.wl-tiwai@suse.de> (raw)
In-Reply-To: <1451470917-30436-1-git-send-email-Julia.Lawall@lip6.fr>
On Wed, 30 Dec 2015 11:21:57 +0100,
Julia Lawall wrote:
>
> The atiixp_dma_ops structures are never modified, so declare them as const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied, thanks.
Takashi
>
> ---
> sound/pci/atiixp.c | 6 +++---
> sound/pci/atiixp_modem.c | 4 ++--
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/sound/pci/atiixp.c b/sound/pci/atiixp.c
> index 1028fc8..2ce0022 100644
> --- a/sound/pci/atiixp.c
> +++ b/sound/pci/atiixp.c
> @@ -1219,7 +1219,7 @@ static struct ac97_pcm atiixp_pcm_defs[] = {
> },
> };
>
> -static struct atiixp_dma_ops snd_atiixp_playback_dma_ops = {
> +static const struct atiixp_dma_ops snd_atiixp_playback_dma_ops = {
> .type = ATI_DMA_PLAYBACK,
> .llp_offset = ATI_REG_OUT_DMA_LINKPTR,
> .dt_cur = ATI_REG_OUT_DMA_DT_CUR,
> @@ -1228,7 +1228,7 @@ static struct atiixp_dma_ops snd_atiixp_playback_dma_ops = {
> .flush_dma = atiixp_out_flush_dma,
> };
>
> -static struct atiixp_dma_ops snd_atiixp_capture_dma_ops = {
> +static const struct atiixp_dma_ops snd_atiixp_capture_dma_ops = {
> .type = ATI_DMA_CAPTURE,
> .llp_offset = ATI_REG_IN_DMA_LINKPTR,
> .dt_cur = ATI_REG_IN_DMA_DT_CUR,
> @@ -1237,7 +1237,7 @@ static struct atiixp_dma_ops snd_atiixp_capture_dma_ops = {
> .flush_dma = atiixp_in_flush_dma,
> };
>
> -static struct atiixp_dma_ops snd_atiixp_spdif_dma_ops = {
> +static const struct atiixp_dma_ops snd_atiixp_spdif_dma_ops = {
> .type = ATI_DMA_SPDIF,
> .llp_offset = ATI_REG_SPDF_DMA_LINKPTR,
> .dt_cur = ATI_REG_SPDF_DMA_DT_CUR,
> diff --git a/sound/pci/atiixp_modem.c b/sound/pci/atiixp_modem.c
> index 27ed678..c534552 100644
> --- a/sound/pci/atiixp_modem.c
> +++ b/sound/pci/atiixp_modem.c
> @@ -970,7 +970,7 @@ static struct snd_pcm_ops snd_atiixp_capture_ops = {
> .pointer = snd_atiixp_pcm_pointer,
> };
>
> -static struct atiixp_dma_ops snd_atiixp_playback_dma_ops = {
> +static const struct atiixp_dma_ops snd_atiixp_playback_dma_ops = {
> .type = ATI_DMA_PLAYBACK,
> .llp_offset = ATI_REG_MODEM_OUT_DMA1_LINKPTR,
> .dt_cur = ATI_REG_MODEM_OUT_DMA1_DT_CUR,
> @@ -979,7 +979,7 @@ static struct atiixp_dma_ops snd_atiixp_playback_dma_ops = {
> .flush_dma = atiixp_out_flush_dma,
> };
>
> -static struct atiixp_dma_ops snd_atiixp_capture_dma_ops = {
> +static const struct atiixp_dma_ops snd_atiixp_capture_dma_ops = {
> .type = ATI_DMA_CAPTURE,
> .llp_offset = ATI_REG_MODEM_IN_DMA_LINKPTR,
> .dt_cur = ATI_REG_MODEM_IN_DMA_DT_CUR,
>
>
prev parent reply other threads:[~2015-12-30 21:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-30 10:21 Julia Lawall
2015-12-30 21:50 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5ha8ortxkz.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=Julia.Lawall@lip6.fr \
--cc=alsa-devel@alsa-project.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®