mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Pavel Hofman <pavel.hofman@insite.cz>
Cc: Wei Ni <wni@nvidia.com>, Peer Chen <pchen@nvidia.com>,
	alsa-devel <alsa-devel@alsa-project.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	akpm <akpm@linux-foundation.org>
Subject: Re: [alsa-devel] [PATCH] add the nvidia HDMI codec driver for	MCP77/79
Date: Thu, 04 Sep 2008 09:04:13 +0200	[thread overview]
Message-ID: <s5habeoo0ia.wl%tiwai@suse.de> (raw)
In-Reply-To: <48BE7EE4.8020800@insite.cz>

At Wed, 03 Sep 2008 14:11:16 +0200,
Pavel Hofman wrote:
> 
> 
> >> ......
> >> According to these codes, It only can get the realtek codec and can not
> >> get hdmi codec, if just change azx_max_codecs[AZX_DRIVER_NVIDIA] to 4
> >> I think if remove "if (!audio_codecs)", it will be better, and I only
> >> need to chang azx_max_codecs[AZX_DRIVER_NVIDIA] to 4
> > 
> > Well, the check is there for a good reason.
> > 
> > There are many machines with broken BIOS reporting the 4th slot
> > available although it isn't actually.  It's a workaround to skip such
> > a bogus information.  So, it cannot be changed so easily.
> > 
> > We need to sort out this in a better way...  Oh well.
> 
> 
> Please, please, put the above information as a comment to the respective 
> place. These "hacks" should be commented :)

I changed that code yesterday with a little bit more comment.

Wei, Peer, could you regenerate the patch based on the latest sound
git tree?

    git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git

or use the snapshot tarball from

    ftp://ftp.kernel.org/pub/linux/tiwai/snapshot/

This already contains the fix for the 4th slot probe on Nvidia
chipset.


thanks,

Takashi

  reply	other threads:[~2008-09-04  7:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-03  7:58 [alsa-devel][PATCH] " peerchen
2008-09-03  8:51 ` Takashi Iwai
2008-09-03 11:05   ` Wei Ni
2008-09-03 12:06     ` Takashi Iwai
2008-09-03 12:11       ` [alsa-devel] [PATCH] " Pavel Hofman
2008-09-04  7:04         ` Takashi Iwai [this message]
2008-09-05  8:28           ` Wei Ni
2008-09-17  9:00             ` Re: [alsa-devel] [PATCH] add the nvidia HDMI codec driverfor MCP77/79 peerchen
2008-09-17 14:04               ` Takashi Iwai
2008-09-19  4:42                 ` Wei Ni
2008-09-22  6:33                 ` Wei Ni
2008-09-22  9:58                   ` Takashi Iwai
2008-09-25  7:14                     ` Wei Ni
2008-09-25  9:55                       ` Takashi Iwai
2008-09-25 11:29                         ` Wei Ni
2008-09-26  6:19                         ` Wei Ni
2008-09-26  8:40                           ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5habeoo0ia.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel.hofman@insite.cz \
    --cc=pchen@nvidia.com \
    --cc=wni@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®