mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Adrian Bunk <bunk@stusta.de>
Cc: George Talusan <gstalusan@uwaterloo.ca>,
	perex@suse.cz, alsa-devel@alsa-project.org,
	linux-kernel@vger.kernel.org
Subject: Re: [Alsa-devel] sound/isa/cmi8330.c: dead ENABLE_SB_MIXER code
Date: Tue, 19 Dec 2006 10:59:15 +0100	[thread overview]
Message-ID: <s5hac1kfbpo.wl%tiwai@suse.de> (raw)
In-Reply-To: <20061204160434.GF30290@stusta.de>

At Mon, 4 Dec 2006 17:04:34 +0100,
Adrian Bunk wrote:
> 
> In sound/isa/cmi8330.c, the ENABLE_SB_MIXER code is currently never 
> used.
> 
> What's the story behind this?
> Should ENABLE_SB_MIXER be enabled?
> Or the code be removed?

CMI8330 has a dual interface for SB and Adlib modes.  The mixer can
also behave differently according to the mode.  The current code has
mixer elements corresponding to both modes.

However, these mixer elements _seem_ to interactive with each other,
and cannot be controlled individually.  That's why ENABLE_SB_MIXER is
disabled.  I cannot check this issue any longer since the test board
got broken long time ago...

I don't think we would get many gain by changing this old code.
(and the relevant part isn't so big.)
Let's keep as it is.


Takashi

  reply	other threads:[~2006-12-19  9:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-04 16:04 Adrian Bunk
2006-12-19  9:59 ` Takashi Iwai [this message]
2006-12-21 20:22   ` [Alsa-devel] " Ondrej Zary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hac1kfbpo.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=bunk@stusta.de \
    --cc=gstalusan@uwaterloo.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®