* [PATCH] ALSA: hda/ca0132: make array ca0132_alt_chmaps static
@ 2018-06-21 18:34 Colin King
2018-06-21 19:43 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2018-06-21 18:34 UTC (permalink / raw)
To: Takashi Iwai, Takashi Sakamoto, alsa-devel; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The array ca0132_alt_chmaps is local to the source and does not
need to be in global scope, so make it static.
Cleans up sparse warning:
warning: symbol 'ca0132_alt_chmaps' was not declared. Should it be
static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
sound/pci/hda/patch_ca0132.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c
index d62c56feaf7d..4ff5320378e2 100644
--- a/sound/pci/hda/patch_ca0132.c
+++ b/sound/pci/hda/patch_ca0132.c
@@ -5665,7 +5665,7 @@ static const char * const ca0132_alt_slave_pfxs[] = {
* I think this has to do with the pin for rear surround being 0x11,
* and the center/lfe being 0x10. Usually the pin order is the opposite.
*/
-const struct snd_pcm_chmap_elem ca0132_alt_chmaps[] = {
+static const struct snd_pcm_chmap_elem ca0132_alt_chmaps[] = {
{ .channels = 2,
.map = { SNDRV_CHMAP_FL, SNDRV_CHMAP_FR } },
{ .channels = 4,
--
2.17.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: hda/ca0132: make array ca0132_alt_chmaps static
2018-06-21 18:34 [PATCH] ALSA: hda/ca0132: make array ca0132_alt_chmaps static Colin King
@ 2018-06-21 19:43 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2018-06-21 19:43 UTC (permalink / raw)
To: Colin King; +Cc: alsa-devel, Takashi Sakamoto, kernel-janitors, linux-kernel
On Thu, 21 Jun 2018 20:34:57 +0200,
Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The array ca0132_alt_chmaps is local to the source and does not
> need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> warning: symbol 'ca0132_alt_chmaps' was not declared. Should it be
> static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-21 19:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-21 18:34 [PATCH] ALSA: hda/ca0132: make array ca0132_alt_chmaps static Colin King
2018-06-21 19:43 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®