* [PATCH v2] sound: oss: Remove useless initialisation
@ 2016-07-12 3:24 Amitoj Kaur Chawla
2016-07-12 6:18 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Amitoj Kaur Chawla @ 2016-07-12 3:24 UTC (permalink / raw)
To: perex, tiwai, alsa-devel, linux-kernel; +Cc: julia.lawall
Remove useless initialisation of variable whose value is reinitialised
later.
The Coccinelle semantic patch used to make this change is as follows:
@@
type T;
identifier x;
constant C;
expression e;
@@
T x
- = C
;
x = e;
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
Changes in v2:
-Modify commit message
sound/oss/ad1848.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/oss/ad1848.c b/sound/oss/ad1848.c
index 10c8de1..6368e5c 100644
--- a/sound/oss/ad1848.c
+++ b/sound/oss/ad1848.c
@@ -254,7 +254,7 @@ static void ad_write(ad1848_info * devc, int reg, int data)
static void wait_for_calibration(ad1848_info * devc)
{
- int timeout = 0;
+ int timeout;
/*
* Wait until the auto calibration process has finished.
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v2] sound: oss: Remove useless initialisation
2016-07-12 3:24 [PATCH v2] sound: oss: Remove useless initialisation Amitoj Kaur Chawla
@ 2016-07-12 6:18 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2016-07-12 6:18 UTC (permalink / raw)
To: Amitoj Kaur Chawla; +Cc: alsa-devel, perex, linux-kernel, julia.lawall
On Tue, 12 Jul 2016 05:24:35 +0200,
Amitoj Kaur Chawla wrote:
>
> Remove useless initialisation of variable whose value is reinitialised
> later.
>
> The Coccinelle semantic patch used to make this change is as follows:
> @@
> type T;
> identifier x;
> constant C;
> expression e;
> @@
>
> T x
> - = C
> ;
> x = e;
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
> Changes in v2:
> -Modify commit message
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-12 6:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-12 3:24 [PATCH v2] sound: oss: Remove useless initialisation Amitoj Kaur Chawla
2016-07-12 6:18 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®