mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Jaroslav Kysela <perex@perex.cz>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ALSA: echoaudio: remove all snd_printk
Date: Mon, 03 Nov 2014 10:42:24 +0100	[thread overview]
Message-ID: <s5hbnoo39j3.wl-tiwai@suse.de> (raw)
In-Reply-To: <1415004383-1515-2-git-send-email-sudipm.mukherjee@gmail.com>

At Mon,  3 Nov 2014 14:16:23 +0530,
Sudip Mukherjee wrote:
> 
> @@ -98,7 +99,7 @@ static int init_hw(struct echoaudio *chip, u16 device_id, u16 subdevice_id)
>  				ECHOCAPS_HAS_DIGITAL_MODE_SPDIF_OPTICAL |
>  				ECHOCAPS_HAS_DIGITAL_MODE_ADAT;
>  
> -	DE_INIT(("init_hw done\n"));
> +	dev_info(chip->card->dev, "init_hw done\n");

This (and the rest of all dev_info() in your patch) should be
dev_dbg().  They are no really useful information to be shown at each
time the module is loaded.  ("init_hw done"?  Yeah, why not, when the
module is loaded successfully :)


thanks,

Takashi

      reply	other threads:[~2014-11-03  9:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-03  8:46 [PATCH 1/2] ALSA: echoaudio: add reference of struct echoaudio Sudip Mukherjee
2014-11-03  8:46 ` [PATCH 2/2] ALSA: echoaudio: remove all snd_printk Sudip Mukherjee
2014-11-03  9:42   ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hbnoo39j3.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®