From: Takashi Iwai <tiwai@suse.de>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sound: pci: ctxfi: ctpcm.c: printk replacement
Date: Mon, 25 Aug 2014 16:03:11 +0200 [thread overview]
Message-ID: <s5hbnr87jkw.wl-tiwai@suse.de> (raw)
In-Reply-To: <1408973692-22742-1-git-send-email-sudipm.mukherjee@gmail.com>
At Mon, 25 Aug 2014 19:04:52 +0530,
Sudip Mukherjee wrote:
>
> replaced printk with corresponding pr_err
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Applied, thanks.
Takashi
> ---
> sound/pci/ctxfi/ctpcm.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/pci/ctxfi/ctpcm.c b/sound/pci/ctxfi/ctpcm.c
> index e8a4feb..6826c2c 100644
> --- a/sound/pci/ctxfi/ctpcm.c
> +++ b/sound/pci/ctxfi/ctpcm.c
> @@ -217,7 +217,7 @@ static int ct_pcm_playback_prepare(struct snd_pcm_substream *substream)
> err = atc->pcm_playback_prepare(atc, apcm);
>
> if (err < 0) {
> - printk(KERN_ERR "ctxfi: Preparing pcm playback failed!!!\n");
> + pr_err("ctxfi: Preparing pcm playback failed!!!\n");
> return err;
> }
>
> @@ -324,7 +324,7 @@ static int ct_pcm_capture_prepare(struct snd_pcm_substream *substream)
>
> err = atc->pcm_capture_prepare(atc, apcm);
> if (err < 0) {
> - printk(KERN_ERR "ctxfi: Preparing pcm capture failed!!!\n");
> + pr_err("ctxfi: Preparing pcm capture failed!!!\n");
> return err;
> }
>
> @@ -435,7 +435,7 @@ int ct_alsa_pcm_create(struct ct_atc *atc,
> err = snd_pcm_new(atc->card, "ctxfi", device,
> playback_count, capture_count, &pcm);
> if (err < 0) {
> - printk(KERN_ERR "ctxfi: snd_pcm_new failed!! Err=%d\n", err);
> + pr_err("ctxfi: snd_pcm_new failed!! Err=%d\n", err);
> return err;
> }
>
> --
> 1.8.1.2
>
prev parent reply other threads:[~2014-08-25 14:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 13:34 Sudip Mukherjee
2014-08-25 14:03 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hbnr87jkw.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®