* [PATCH -next] ALSA: lx6464es - Remove set but not used variables 'orun_mask, urun_mask'
@ 2019-06-01 4:12 YueHaibing
2019-06-11 9:35 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-06-01 4:12 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai, Kate Stewart, Greg Kroah-Hartman,
Thomas Gleixner, Allison Randal
Cc: YueHaibing, alsa-devel, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
sound/pci/lx6464es/lx_core.c: In function 'lx_interrupt_handle_async_events':
sound/pci/lx6464es/lx_core.c:990:6: warning:
variable 'urun_mask' set but not used [-Wunused-but-set-variable]
sound/pci/lx6464es/lx_core.c:989:6: warning:
variable 'orun_mask' set but not used [-Wunused-but-set-variable]
They are never used, so can be removed.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
sound/pci/lx6464es/lx_core.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/sound/pci/lx6464es/lx_core.c b/sound/pci/lx6464es/lx_core.c
index 9236a1a8c49b..dd3a873777eb 100644
--- a/sound/pci/lx6464es/lx_core.c
+++ b/sound/pci/lx6464es/lx_core.c
@@ -986,8 +986,6 @@ static int lx_interrupt_handle_async_events(struct lx6464es *chip, u32 irqsrc,
* Stat[8] LSB overrun
* */
- u64 orun_mask;
- u64 urun_mask;
int eb_pending_out = (irqsrc & MASK_SYS_STATUS_EOBO) ? 1 : 0;
int eb_pending_in = (irqsrc & MASK_SYS_STATUS_EOBI) ? 1 : 0;
@@ -1010,9 +1008,6 @@ static int lx_interrupt_handle_async_events(struct lx6464es *chip, u32 irqsrc,
*r_notified_out_pipe_mask);
}
- orun_mask = ((u64)stat[7] << 32) + stat[8];
- urun_mask = ((u64)stat[5] << 32) + stat[6];
-
/* todo: handle xrun notification */
return err;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] ALSA: lx6464es - Remove set but not used variables 'orun_mask, urun_mask'
2019-06-01 4:12 [PATCH -next] ALSA: lx6464es - Remove set but not used variables 'orun_mask, urun_mask' YueHaibing
@ 2019-06-11 9:35 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2019-06-11 9:35 UTC (permalink / raw)
To: YueHaibing
Cc: Thomas Gleixner, Greg Kroah-Hartman, KateStewart, AllisonRandal,
Jaroslav Kysela, alsa-devel, kernel-janitors, linux-kernel
On Sat, 01 Jun 2019 06:12:14 +0200,
YueHaibing wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> sound/pci/lx6464es/lx_core.c: In function 'lx_interrupt_handle_async_events':
> sound/pci/lx6464es/lx_core.c:990:6: warning:
> variable 'urun_mask' set but not used [-Wunused-but-set-variable]
> sound/pci/lx6464es/lx_core.c:989:6: warning:
> variable 'orun_mask' set but not used [-Wunused-but-set-variable]
>
> They are never used, so can be removed.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-11 9:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-01 4:12 [PATCH -next] ALSA: lx6464es - Remove set but not used variables 'orun_mask, urun_mask' YueHaibing
2019-06-11 9:35 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®