From: Takashi Iwai <tiwai@suse.de>
To: Julia Lawall <julia@diku.dk>
Cc: perex@perex.cz, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] sound: Use usb_set/get_intfdata
Date: Fri, 02 Jan 2009 11:53:52 +0100 [thread overview]
Message-ID: <s5hd4f6htbz.wl%tiwai@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0901011814080.20447@pc-004.diku.dk>
At Thu, 1 Jan 2009 18:14:35 +0100 (CET),
Julia Lawall wrote:
>
> From: Julia Lawall <julia@diku.dk>
>
> Use the USB functions usb_get_intfdata and usb_set_intfdata instead of
> dev_get_drvdata and dev_set_drvdata, respectively.
>
> The semantic patch that makes this change for the usb_get_intfdata case is
> as follows: (http://www.emn.fr/x-info/coccinelle/)
>
> // <smpl>
> @header@
> @@
>
> #include <linux/usb.h>
>
> @same depends on header@
> position p;
> @@
>
> usb_get_intfdata@p(...) { ... }
>
> @depends on header@
> position _p!=same.p;
> identifier _f;
> struct usb_interface*intf;
> @@
>
> _f@_p(...) { <+...
> - dev_get_drvdata(&intf->dev)
> + usb_get_intfdata(intf)
> ...+> }
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2009-01-02 10:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-01 17:14 Julia Lawall
2009-01-02 10:53 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hd4f6htbz.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®