mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Amit Choudhary <amit2030@gmail.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [KJ] [PATCH] sound/isa/gus/interwave.c: check kmalloc() return value.
Date: Mon, 09 Oct 2006 16:40:45 +0200	[thread overview]
Message-ID: <s5hd591r1qq.wl%tiwai@suse.de> (raw)
In-Reply-To: <20061007003155.1374ed08.amit2030@gmail.com>

At Sat, 7 Oct 2006 00:31:55 -0700,
Amit Choudhary wrote:
> 
> Description: Check the return value of kmalloc() in function snd_interwave_pnp(), in file sound/isa/gus/interwave.c.
> 
> Signed-off-by: Amit Choudhary <amit2030@gmail.com>

Thanks, I merged these patches to ALSA tree now.


Takashi

> 
> diff --git a/sound/isa/gus/interwave.c b/sound/isa/gus/interwave.c
> index ea69f25..5282fbb 100644
> --- a/sound/isa/gus/interwave.c
> +++ b/sound/isa/gus/interwave.c
> @@ -564,6 +564,8 @@ static int __devinit snd_interwave_pnp(i
>  	struct pnp_resource_table * cfg = kmalloc(sizeof(struct pnp_resource_table), GFP_KERNEL);
>  	int err;
>  
> +	if (!cfg)
> +		return -ENOMEM;
>  	iwcard->dev = pnp_request_card_device(card, id->devs[0].id, NULL);
>  	if (iwcard->dev == NULL) {
>  		kfree(cfg);
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

      reply	other threads:[~2006-10-09 14:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-07  7:31 Amit Choudhary
2006-10-09 14:40 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hd591r1qq.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=amit2030@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome