mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "RAVULAPATI, VISHNU VARDHAN RAO"  <Vishnuvardhanrao.Ravulapati@amd.com>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	"moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
	MANAGEM..."  <alsa-devel@alsa-project.org>,
	Maruthi Srinivas Bayyavarapu <Maruthi.Bayyavarapu@amd.com>,
	open list <linux-kernel@vger.kernel.org>,
	Takashi Iwai <tiwai@suse.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	"Agrawal, Akshu" <Akshu.Agrawal@amd.com>,
	Mark Brown <broonie@kernel.org>,
	"djkurtz@google.com" <djkurtz@google.com>,
	"Mukunda, Vijendar" <Vijendar.Mukunda@amd.com>,
	"Deucher, Alexander" <Alexander.Deucher@amd.com>,
	Colin Ian King <colin.king@canonical.com>,
	Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [alsa-devel] [RESEND PATCH v4 1/6] ASoC: amd:Create multiple I2S platform device Endpoint
Date: Mon, 11 Nov 2019 18:20:17 +0100	[thread overview]
Message-ID: <s5heeyeuy7i.wl-tiwai@suse.de> (raw)
In-Reply-To: <DM6PR12MB3868D380B280936C902FF67BE7740@DM6PR12MB3868.namprd12.prod.outlook.com>

On Mon, 11 Nov 2019 18:16:25 +0100,
RAVULAPATI, VISHNU VARDHAN RAO wrote:
> 
> > +             pdevinfo[2].name = "acp3x_i2s_playcap";
> > +             pdevinfo[2].id = 1;
> > +             pdevinfo[2].parent = &pci->dev;
> > +             pdevinfo[2].num_res = 1;
> > +             pdevinfo[2].res = &adata->res[2];
> > +             for (i = 0; i < ACP3x_DEVS ; i++) {
> > +                     adata->pdev[i] =
> > +                             platform_device_register_full(&pdevinfo[i]);
> > +                     IS_ERR(adata->pdev[i]) {
> 
> how does this even compile?
> 
> I have not faced any issue of compilation.
> Can I know what is wrong with it please so that it can be re checked.

The "if" is missing around IS_ERR() in the above line.
It should have been
			if (IS_ERR(adata->pdev[i])) {
				.....


It's interesting the code didn't give any compile warning or error,
indeed.


thanks,

Takashi

  parent reply	other threads:[~2019-11-11 17:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1573483794-8921-1-git-send-email-Vishnuvardhanrao.Ravulapati@amd.com>
2019-11-11 14:49 ` Ravulapati Vishnu vardhan rao
2019-11-11 15:44   ` [alsa-devel] " Pierre-Louis Bossart
     [not found]   ` <DM6PR12MB3868D380B280936C902FF67BE7740@DM6PR12MB3868.namprd12.prod.outlook.com>
2019-11-11 17:20     ` Takashi Iwai [this message]
2019-11-11 14:49 ` [PATCH v4 2/6] ASoC: amd: Refactoring of DAI from DMA driver Ravulapati Vishnu vardhan rao
2019-11-11 14:49 ` [PATCH v4 3/6] ASoC: amd: Enabling I2S instance in DMA and DAI Ravulapati Vishnu vardhan rao
2019-11-11 14:49 ` [RESEND PATCH v4 4/6] ASoC: amd: add ACP3x TDM mode support Ravulapati Vishnu vardhan rao
2019-11-11 14:49 ` [PATCH v4 5/6] ASoC: amd: handle ACP3x i2s-sp interrupt Ravulapati Vishnu vardhan rao
2019-11-11 14:49 ` [PATCH v4 6/6] ASoC: amd: Added ACP3x system resume and runtime pm Ravulapati Vishnu vardhan rao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5heeyeuy7i.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=Akshu.Agrawal@amd.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=Maruthi.Bayyavarapu@amd.com \
    --cc=Vijendar.Mukunda@amd.com \
    --cc=Vishnuvardhanrao.Ravulapati@amd.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=colin.king@canonical.com \
    --cc=dan.carpenter@oracle.com \
    --cc=djkurtz@google.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®