From: Takashi Iwai <tiwai@suse.de>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Con Kolivas <con@kolivas.org>,
Bhumika Goyal <bhumirks@gmail.com>,
Stephen Barber <smbarber@chromium.org>,
alsa-devel@alsa-project.org, LKML <linux-kernel@vger.kernel.org>,
Kostya Serebryany <kcc@google.com>,
syzkaller <syzkaller@googlegroups.com>,
Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [alsa-devel] usb/sound: slab-out-of-bounds in parse_audio_unit
Date: Tue, 21 Nov 2017 17:26:48 +0100 [thread overview]
Message-ID: <s5heforvbqv.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAAeHK+wr2ka_B6RAw+0ygzb_YRoATOZF89HDNoOCVj+4Wm0j1Q@mail.gmail.com>
On Tue, 21 Nov 2017 14:51:56 +0100,
Andrey Konovalov wrote:
>
> Hi!
>
> I've got the following report while fuzzing the kernel with syzkaller.
>
> On commit e1d1ea549b57790a3d8cf6300e6ef86118d692a3 (4.15-rc1).
>
> ==================================================================
> BUG: KASAN: slab-out-of-bounds in parse_audio_unit+0x2e08/0x31d0
> Read of size 1 at addr ffff88006998ff20 by task kworker/1:1/1495
>
> CPU: 1 PID: 1495 Comm: kworker/1:1 Not tainted 4.14.0-57501-g9284d204d604 #119
> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011
> Workqueue: usb_hub_wq hub_event
> Call Trace:
> __dump_stack lib/dump_stack.c:17
> dump_stack+0xe1/0x157 lib/dump_stack.c:53
> print_address_description+0x71/0x234 mm/kasan/report.c:252
> kasan_report_error mm/kasan/report.c:351
> kasan_report+0x173/0x270 mm/kasan/report.c:409
> __asan_report_load1_noabort+0x19/0x20 mm/kasan/report.c:427
> parse_audio_feature_unit sound/usb/mixer.c:1472
Looks like that a malformed feature unit descriptor is passed while
the usb-audio driver is too naive to believe in a perfect world.
I'll provide a fix patch.
thanks,
Takashi
prev parent reply other threads:[~2017-11-21 16:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 13:51 Andrey Konovalov
2017-11-21 16:26 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5heforvbqv.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=andreyknvl@google.com \
--cc=bhumirks@gmail.com \
--cc=con@kolivas.org \
--cc=dvyukov@google.com \
--cc=kcc@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=smbarber@chromium.org \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®