mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Arnd Bergmann" <arnd@arndb.de>
Cc: "Jaroslav Kysela" <perex@perex.cz>, <alsa-devel@alsa-project.org>,
	"Jerome Anand" <jerome.anand@intel.com>,
	"Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: x86: hdmi: select CONFIG_SND_PCM
Date: Tue, 21 Feb 2017 23:40:22 +0100	[thread overview]
Message-ID: <s5hefyrnp61.wl-tiwai@suse.de> (raw)
In-Reply-To: <20170221220255.242105-1-arnd@arndb.de>

On Tue, 21 Feb 2017 23:02:37 +0100,
Arnd Bergmann wrote:
> 
> The newly added driver uses the PCM helpers and fails to link if they are disabled:
> 
> sound/built-in.o: In function `hdmi_lpe_audio_runtime_suspend':
> intel_hdmi_audio.c:(.text+0x15906): undefined reference to `snd_pcm_suspend'
> sound/built-in.o: In function `had_pcm_hw_params':
> intel_hdmi_audio.c:(.text+0x15ac7): undefined reference to `snd_pcm_lib_malloc_pages'
> sound/built-in.o: In function `had_pcm_open':
> intel_hdmi_audio.c:(.text+0x15d49): undefined reference to `snd_pcm_hw_constraint_integer'
> 
> This uses a Kconfig 'select' statement to make sure they are enabled.
> 
> Fixes: 5dab11d89777 ("ALSA: x86: hdmi: Add audio support for BYT and CHT")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks, applied.


Takashi

      reply	other threads:[~2017-02-21 22:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-21 22:02 Arnd Bergmann
2017-02-21 22:40 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hefyrnp61.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnd@arndb.de \
    --cc=jerome.anand@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®