From: Takashi Iwai <tiwai@suse.de>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: broonie@kernel.org, alsa-devel@alsa-project.org,
patches@opensource.wolfsonmicro.com, dmitry.torokhov@gmail.com,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
cw00.choi@samsung.com, myungjoo.ham@samsung.com
Subject: Re: [alsa-devel] [PATCH] ASoC: dapm: Add locking to snd_soc_dapm_xxxx_pin functions
Date: Wed, 12 Feb 2014 12:31:05 +0100 [thread overview]
Message-ID: <s5heh387ekm.wl%tiwai@suse.de> (raw)
In-Reply-To: <20140212112640.GE16684@opensource.wolfsonmicro.com>
At Wed, 12 Feb 2014 11:26:40 +0000,
Charles Keepax wrote:
>
> On Mon, Feb 10, 2014 at 02:05:26PM +0100, Takashi Iwai wrote:
> > At Mon, 10 Feb 2014 11:05:36 +0000,
> > Charles Keepax wrote:
> > >
> <snip>
> > >
> > Actually, this fixes also the double-lock in snd_soc_dapm_sync() call
> > in the line below the above. snd_soc_dapm_sync() itself takes
> > mutex_lock_nested().
>
> Yeah spotted that as I was going through will do this in a
> seperate patch if this one doesn't go in.
As the deadlock seems present since long time ago, it'd be better to
have a fix patch (for stable kernels), then move to the new scheme, if
any.
Takashi
next prev parent reply other threads:[~2014-02-12 11:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 11:05 Charles Keepax
2014-02-10 12:08 ` Mark Brown
2014-02-12 11:24 ` Charles Keepax
2014-02-12 15:44 ` Mark Brown
2014-02-10 13:05 ` [alsa-devel] " Takashi Iwai
2014-02-12 11:26 ` Charles Keepax
2014-02-12 11:31 ` Takashi Iwai [this message]
2014-02-10 13:47 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5heh387ekm.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=cw00.choi@samsung.com \
--cc=dmitry.torokhov@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®