mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-dvb-maintainer@linuxtv.org, video4linux-list@redhat.com,
	linux-kernel@vger.kernel.org, Mike Galbraith <efault@gmx.de>
Subject: Re: [patch, -git] media/video/sound build fix, TEA5761/TEA5767
Date: Wed, 30 Apr 2008 13:58:06 +0200	[thread overview]
Message-ID: <s5hej8nwo4x.wl%tiwai@suse.de> (raw)
In-Reply-To: <20080430112138.GA11844@elte.hu>

At Wed, 30 Apr 2008 13:21:38 +0200,
Ingo Molnar wrote:
> 
> Subject: sound/video: sound/i2c/other/tea575x-tuner.c build fix
> From: Ingo Molnar <mingo@elte.hu>
> Date: Tue Apr 29 22:40:31 CEST 2008
> 
> fix build failure triggered by this config:
> 
>  http://redhat.com/~mingo/misc/config-Tue_Apr_29_22_33_36_CEST_2008.bad
> 
> sound/i2c/other/tea575x-tuner.c: In function 'snd_tea575x_ioctl':
> sound/i2c/other/tea575x-tuner.c:95: error: 'VIDIOCGCAP' undeclared (first use in this function)
> sound/i2c/other/tea575x-tuner.c:95: error: (Each undeclared identifier is reported only once
> sound/i2c/other/tea575x-tuner.c:95: error: for each function it appears in.)
> sound/i2c/other/tea575x-tuner.c:97: error: storage size of 'v' isn't known
> 
> that code still depends on VIDEO_V4L1_COMPAT APIs.
> 
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> ---
>  sound/pci/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> Index: linux/sound/pci/Kconfig
> ===================================================================
> --- linux.orig/sound/pci/Kconfig
> +++ linux/sound/pci/Kconfig
> @@ -527,6 +527,7 @@ config SND_FM801_TEA575X
>  	tristate
>  	depends on SND_FM801_TEA575X_BOOL
>  	default SND_FM801
> +	select VIDEO_V4L1_COMPAT
>  
>  config SND_HDA_INTEL
>  	tristate "Intel HD Audio"

This one shouldn't be needed with my patch.


Takashi

  reply	other threads:[~2008-04-30 11:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-30 11:01 Ingo Molnar
2008-04-30 11:11 ` Takashi Iwai
2008-04-30 11:15   ` Ingo Molnar
2008-04-30 11:18     ` Ingo Molnar
2008-04-30 11:21       ` Ingo Molnar
2008-04-30 11:58         ` Takashi Iwai [this message]
2008-04-30 12:05           ` Ingo Molnar
2008-04-30 12:36         ` [v4l-dvb-maintainer] " Michael Krufky
2008-04-30 12:01       ` Takashi Iwai
2008-04-30 11:17   ` David Miller
2008-04-30 11:29     ` Sam Ravnborg
2008-04-30 12:09       ` Takashi Iwai
2008-04-30 12:18       ` Ingo Molnar
2008-05-02 15:06         ` Sam Ravnborg
2008-05-05 20:34           ` Mauro Carvalho Chehab
2008-04-30 11:54     ` Takashi Iwai
2008-04-30 11:13 ` Ingo Molnar
2008-04-30 12:04   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hej8nwo4x.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=efault@gmx.de \
    --cc=linux-dvb-maintainer@linuxtv.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=mingo@elte.hu \
    --cc=video4linux-list@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®