mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Lucas Tanure <tanureal@opensource.cirrus.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>, Hans de Goede <hdegoede@redhat.com>,
	Mark Gross <markgross@kernel.org>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	<alsa-devel@alsa-project.org>, <linux-acpi@vger.kernel.org>,
	<patches@opensource.cirrus.com>,
	<platform-driver-x86@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] ALSA: hda: cs35l41: Tidyup code and add default cases
Date: Fri, 14 Jan 2022 17:15:31 +0100	[thread overview]
Message-ID: <s5hfspq47ks.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220113170728.1953559-4-tanureal@opensource.cirrus.com>

On Thu, 13 Jan 2022 18:07:27 +0100,
Lucas Tanure wrote:
> 
> Clean up the code, plus adding default cases for switch
> and dev_err_probe use.

Please split to patches.  There are too much mixed up of changes for
different goals.  There is difference between a white-space cleanup or
such (that is, no significant change of the resultant binary), a
cleanup with a better API usage, and a code refactoring.  And, the
addition of the missing default case is rather the fix, not a clean
up...


thanks,

Takashi

  parent reply	other threads:[~2022-01-14 16:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-13 17:07 [PATCH 1/5] ALSA: hda: cs35l41: Avoid overwriting register patch Lucas Tanure
2022-01-13 17:07 ` [PATCH 2/5] ALSA: hda: cs35l41: Add calls to newly added test key function Lucas Tanure
2022-01-14 16:14   ` Cezary Rojewski
2022-01-13 17:07 ` [PATCH 3/5] ALSA: hda: cs35l41: Move cs35l41* calls to its own symbol namespace Lucas Tanure
2022-01-13 17:07 ` [PATCH 4/5] ALSA: hda: cs35l41: Tidyup code and add default cases Lucas Tanure
2022-01-14 13:04   ` Lucas tanure
2022-01-14 16:15   ` Takashi Iwai [this message]
2022-01-13 17:07 ` [PATCH 5/5] ACPI / scan: Create platform device for CLSA0100 Lucas Tanure
2022-01-14 16:19   ` Takashi Iwai
2022-01-14 17:51     ` Rafael J. Wysocki
2022-01-14 18:56       ` Hans de Goede
2022-01-15  6:59         ` Takashi Iwai
2022-01-17 10:47           ` tanureal
2022-01-14 16:06 ` [PATCH 1/5] ALSA: hda: cs35l41: Avoid overwriting register patch Cezary Rojewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hfspq47ks.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=hdegoede@redhat.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markgross@kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=tanureal@opensource.cirrus.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome