From: Takashi Iwai <tiwai@suse.de>
To: "Matthias Kaehlcke" <mka@chromium.org>
Cc: "Julia Lawall" <Julia.Lawall@lip6.fr>,
"Jaroslav Kysela" <perex@perex.cz>,
"Sven Hahne" <hahne@zeitkunst.eu>, <alsa-devel@alsa-project.org>,
"Grant Grundler" <grundler@chromium.org>,
"Greg Hackmann" <ghackmann@google.com>,
"Michael Davidson" <md@google.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ALSA: hda/ca0132: Limit values for chip addresses to 32-bit
Date: Sat, 01 Apr 2017 10:46:53 +0200 [thread overview]
Message-ID: <s5hfuhsfrb6.wl-tiwai@suse.de> (raw)
In-Reply-To: <20170401010005.90685-1-mka@chromium.org>
On Sat, 01 Apr 2017 03:00:04 +0200,
Matthias Kaehlcke wrote:
>
> With the previous unsigned long value clang generates warnings like
> this:
>
> sound/pci/hda/patch_ca0132.c:860:37: error: implicit conversion from
> 'unsigned long' to 'u32' (aka 'unsigned int') changes value from
> 18446744073709551615 to 4294967295 [-Werror,-Wconstant-conversion]
> spec->curr_chip_addx = (res < 0) ? ~0UL : chip_addx;
> ~ ^~~~
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Thanks, applied.
Takashi
> ---
> Changes in v2:
> - Remove unnecessary cast to u32
>
> sound/pci/hda/patch_ca0132.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c
> index 07a9deb17477..2023fe472be1 100644
> --- a/sound/pci/hda/patch_ca0132.c
> +++ b/sound/pci/hda/patch_ca0132.c
> @@ -857,7 +857,7 @@ static int chipio_write_address(struct hda_codec *codec,
> chip_addx >> 16);
> }
>
> - spec->curr_chip_addx = (res < 0) ? ~0UL : chip_addx;
> + spec->curr_chip_addx = (res < 0) ? ~0U : chip_addx;
>
> return res;
> }
> @@ -882,7 +882,7 @@ static int chipio_write_data(struct hda_codec *codec, unsigned int data)
> /*If no error encountered, automatically increment the address
> as per chip behaviour*/
> spec->curr_chip_addx = (res != -EIO) ?
> - (spec->curr_chip_addx + 4) : ~0UL;
> + (spec->curr_chip_addx + 4) : ~0U;
> return res;
> }
>
> @@ -933,7 +933,7 @@ static int chipio_read_data(struct hda_codec *codec, unsigned int *data)
> /*If no error encountered, automatically increment the address
> as per chip behaviour*/
> spec->curr_chip_addx = (res != -EIO) ?
> - (spec->curr_chip_addx + 4) : ~0UL;
> + (spec->curr_chip_addx + 4) : ~0U;
> return res;
> }
>
> --
> 2.12.2.564.g063fe858b8-goog
>
>
prev parent reply other threads:[~2017-04-01 8:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-01 1:00 Matthias Kaehlcke
2017-04-01 8:46 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hfuhsfrb6.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=Julia.Lawall@lip6.fr \
--cc=alsa-devel@alsa-project.org \
--cc=ghackmann@google.com \
--cc=grundler@chromium.org \
--cc=hahne@zeitkunst.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=md@google.com \
--cc=mka@chromium.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®