mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Luis de Bethencourt" <luis@debethencourt.com>
Cc: <linux-kernel@vger.kernel.org>, <alsa-devel@alsa-project.org>,
	"Javier Martinez Canillas" <javier@osg.samsung.com>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Wolfram Sang" <wsa@the-dreams.de>,
	"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>
Subject: Re: [PATCH] ALSA: sparc: amd7930: Fix module autoload for OF platform driver
Date: Fri, 04 Sep 2015 12:14:18 +0200	[thread overview]
Message-ID: <s5hfv2ujxtx.wl-tiwai@suse.de> (raw)
In-Reply-To: <20150903110304.GA17142@goodgumbo.baconseed.org>

On Thu, 03 Sep 2015 13:03:04 +0200,
Luis de Bethencourt wrote:
> 
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
> 
> Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>

Applied, thanks.


Takashi

> ---
> 
> Hello,
> 
> This patch adds the missing MODULE_DEVICE_TABLE() for OF to eport
> that information so modules have the correct aliases built-in and
> autoloading works correctly.
> 
> A longer explanation by Javier Canillas can be found here:
> https://lkml.org/lkml/2015/7/30/519
> 
> Thanks,
> Luis
> 
>  sound/sparc/amd7930.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/sparc/amd7930.c b/sound/sparc/amd7930.c
> index 784ceb8..35c1f6a 100644
> --- a/sound/sparc/amd7930.c
> +++ b/sound/sparc/amd7930.c
> @@ -1064,6 +1064,7 @@ static const struct of_device_id amd7930_match[] = {
>  	},
>  	{},
>  };
> +MODULE_DEVICE_TABLE(of, amd7930_match);
>  
>  static struct platform_driver amd7930_sbus_driver = {
>  	.driver = {
> -- 
> 2.4.6
> 
> 

      reply	other threads:[~2015-09-04 10:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-03 11:03 Luis de Bethencourt
2015-09-04 10:14 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hfv2ujxtx.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=javier@osg.samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luis@debethencourt.com \
    --cc=perex@perex.cz \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®