From: Takashi Iwai <tiwai@suse.de>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Wolfram Sang <w.sang@pengutronix.de>,
Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/2] ALSA: keywest: Remove obsolete cleanup for clientdata
Date: Mon, 12 Sep 2011 13:58:46 +0200 [thread overview]
Message-ID: <s5hfwk26kg9.wl%tiwai@suse.de> (raw)
In-Reply-To: <1315561852.2831.1.camel@phoenix>
At Fri, 09 Sep 2011 17:50:52 +0800,
Axel Lin wrote:
>
> The i2c core will clear the clientdata pointer automatically.
> We don't have to set the `data' field to NULL in remove() or
> if probe() failed anymore.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Applied now. Thanks.
Takashi
> ---
> sound/ppc/keywest.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/sound/ppc/keywest.c b/sound/ppc/keywest.c
> index 8f064c7..4080bec 100644
> --- a/sound/ppc/keywest.c
> +++ b/sound/ppc/keywest.c
> @@ -82,7 +82,6 @@ static int keywest_attach_adapter(struct i2c_adapter *adapter)
>
> static int keywest_remove(struct i2c_client *client)
> {
> - i2c_set_clientdata(client, NULL);
> if (! keywest_ctx)
> return 0;
> if (client == keywest_ctx->client)
> --
> 1.7.4.1
>
>
>
next prev parent reply other threads:[~2011-09-12 11:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-09 9:49 [PATCH 1/2] ALSA: aoa: " Axel Lin
2011-09-09 9:50 ` [PATCH 2/2] ALSA: keywest: " Axel Lin
2011-09-09 10:08 ` Wolfram Sang
2011-09-12 11:58 ` Takashi Iwai [this message]
2011-09-09 10:05 ` [PATCH 1/2] ALSA: aoa: " Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hfwk26kg9.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®