mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Ondrej Zary <linux@rainbow-software.org>
Cc: linux-media@vger.kernel.org, alsa-devel@alsa-project.org,
	Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH RFC] radio-sf16fmr2: convert to generic TEA575x	interface
Date: Sat, 14 May 2011 12:01:12 +0200	[thread overview]
Message-ID: <s5hfwoh4n4n.wl%tiwai@suse.de> (raw)
In-Reply-To: <201105140017.26968.linux@rainbow-software.org>

At Sat, 14 May 2011 00:17:23 +0200,
Ondrej Zary wrote:
> 
> Hello,
> the SF16-FMR2 radio card is basically a TEA5757 tuner connected to ISA bus but
> the driver currently uses its own implementation. I converted the driver to
> use generic tea575x-tuner implementation (see patch below) and it works fine.
> 
> But the tea575x-tuner module is located in /sound/i2c/other and the
> corresponding Kconfig in /sound/pci. Should it be moved
> to /drivers/media/radio or better leave it as is?

That would be a feasible option.
Actually no ALSA-specific data / function is used in tea575x-tuner.c,
so it'd be more natural to put it to drivers/media/radio.
(And remove the inclusion of <sound/*> from relevant files.)


thanks,

Takashi

  reply	other threads:[~2011-05-14 10:01 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-13 22:17 Ondrej Zary
2011-05-14 10:01 ` Takashi Iwai [this message]
2011-05-14 10:06 ` Hans Verkuil
2011-05-15 19:41   ` [PATCH RFC] tea575x: convert to control framework Ondrej Zary
2011-05-15 20:18   ` [PATCH RFC v2] radio-sf16fmr2: convert to generic TEA575x interface Ondrej Zary
2011-05-15 21:26     ` Hans Verkuil
2011-05-17 19:33       ` Hans Verkuil
2011-05-17 20:05         ` Ondrej Zary
2011-05-18  6:26           ` Hans Verkuil
2011-05-18 21:38             ` [PATCH v4] " Ondrej Zary
2011-05-17 21:45         ` [PATCH RFC v2] tea575x: convert to control framework Ondrej Zary
2011-05-18  6:21           ` Hans Verkuil
2011-05-18 19:36             ` [PATCH v3] " Ondrej Zary
2011-05-18 20:25               ` Hans Verkuil
2011-05-18 21:35                 ` [PATCH v4] " Ondrej Zary
2011-05-19  6:45                   ` Hans Verkuil
2011-05-19 16:11                     ` [PATCH v5] " Ondrej Zary
2011-05-19 20:54                       ` Hans Verkuil
2011-05-19 16:15                     ` [PATCH v5] radio-sf16fmr2: convert to generic TEA575x interface Ondrej Zary
2011-05-19 20:56                       ` Hans Verkuil
2011-05-17 21:45         ` [PATCH RFC v3] " Ondrej Zary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hfwoh4n4n.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux@rainbow-software.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®