mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Rajesh Kumbhakar <sssraj.sssraj@gmail.com>
Cc: perex@perex.cz, tiwai@suse.com, sfr@canb.auug.org.au,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sound: core: fixed coding style errors
Date: Tue, 23 Feb 2021 07:39:05 +0100	[thread overview]
Message-ID: <s5hh7m3wanq.wl-tiwai@suse.de> (raw)
In-Reply-To: <20210222194156.26758-1-sssraj.sssraj@gmail.com>

On Mon, 22 Feb 2021 20:41:56 +0100,
Rajesh Kumbhakar wrote:
> 
> fixing ERROR: "foo * bar" should be "foo *bar"
> fixing WARNING: Missing a blank line after declarations
> 
> Signed-off-by: Rajesh Kumbhakar <sssraj.sssraj@gmail.com>
> ---
>  sound/core/hwdep_compat.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/core/hwdep_compat.c b/sound/core/hwdep_compat.c
> index a0b76706c..d8624a14a 100644
> --- a/sound/core/hwdep_compat.c
> +++ b/sound/core/hwdep_compat.c
> @@ -36,11 +36,13 @@ enum {
>  	SNDRV_HWDEP_IOCTL_DSP_LOAD32   = _IOW('H', 0x03, struct snd_hwdep_dsp_image32)
>  };
>  
> -static long snd_hwdep_ioctl_compat(struct file * file, unsigned int cmd,
> +static long snd_hwdep_ioctl_compat(struct file *file, unsigned int cmd,
>  				   unsigned long arg)
>  {
>  	struct snd_hwdep *hw = file->private_data;
> +
>  	void __user *argp = compat_ptr(arg);

You shouldn't put a blank line here.


thanks,

Takashi

  reply	other threads:[~2021-02-23  6:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-22 19:41 Rajesh Kumbhakar
2021-02-23  6:39 ` Takashi Iwai [this message]
2021-02-23  6:47   ` Rajesh Kumbhakar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hh7m3wanq.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=sfr@canb.auug.org.au \
    --cc=sssraj.sssraj@gmail.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®