mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: mgross@linux.intel.com
Cc: linux-pm <linux-pm@lists.linux-foundation.org>,
	lkml <linux-kernel@vger.kernel.org>,
	perex@perex.cz, alsa-devel@alsa-project.org
Subject: Re: [PATCH]PM_QOS-to-use-handle-based-requests-pcm-update 5/5
Date: Wed, 02 Dec 2009 12:38:07 +0100	[thread overview]
Message-ID: <s5hiqcpy5b4.wl%tiwai@suse.de> (raw)
In-Reply-To: <20091201213840.GE19688@linux.intel.com>

At Tue, 1 Dec 2009 13:38:40 -0800,
mark gross wrote:
> 
> --- a/sound/core/pcm_native.c
> +++ b/sound/core/pcm_native.c
(snip)
> @@ -506,8 +508,8 @@ static int snd_pcm_hw_free(struct snd_pcm_substream *substream)
>  	if (substream->ops->hw_free)
>  		result = substream->ops->hw_free(substream);
>  	runtime->status->state = SNDRV_PCM_STATE_OPEN;
> -	pm_qos_remove_requirement(PM_QOS_CPU_DMA_LATENCY,
> -		substream->latency_id);
> +	pm_qos_remove_request(substream->latency_pm_qos_req);

The NULL check seems needed in the caller side because
pm_qos_remove_request() doesn't do it.

Or, would you add a NULL check in pm_qos_remove_request()?
It'd be more handy.


thanks,

Takashi

  reply	other threads:[~2009-12-02 11:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-01 21:38 mark gross
2009-12-02 11:38 ` Takashi Iwai [this message]
2009-12-02 21:50   ` mark gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hiqcpy5b4.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=mgross@linux.intel.com \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®