From: Takashi Iwai <tiwai@suse.de>
To: Julia Lawall <julia@diku.dk>
Cc: perex@perex.cz, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] sound/pci/mixart/mixart.c: Add missing snd_card_free
Date: Thu, 27 Nov 2008 14:43:06 +0100 [thread overview]
Message-ID: <s5hk5apz3md.wl%tiwai@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0811271432350.15160@pc-004.diku.dk>
At Thu, 27 Nov 2008 14:33:30 +0100 (CET),
Julia Lawall wrote:
>
> Oops, please ignore this patch. There is a problem, but the modification
> is not correct.
How about the patch below?
Takashi
---
diff --git a/sound/pci/mixart/mixart.c b/sound/pci/mixart/mixart.c
index ae7601f..3cccfed 100644
--- a/sound/pci/mixart/mixart.c
+++ b/sound/pci/mixart/mixart.c
@@ -989,6 +989,7 @@ static int snd_mixart_pcm_digital(struct snd_mixart *chip)
static int snd_mixart_chip_free(struct snd_mixart *chip)
{
+ chip->mgr->chip[chip->chip_idx] = NULL;
kfree(chip);
return 0;
}
next prev parent reply other threads:[~2008-11-27 13:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-27 13:23 Julia Lawall
2008-11-27 13:33 ` Julia Lawall
2008-11-27 13:43 ` Takashi Iwai [this message]
2008-11-27 14:01 ` Julia Lawall
2008-11-27 14:36 ` Takashi Iwai
2008-11-27 14:40 ` Julia Lawall
2008-11-27 15:04 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hk5apz3md.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®