* [PATCH -next] ALSA: ac97: remove unused variable 'snd_ac97_controls_master_mono'
@ 2019-08-09 9:01 YueHaibing
2019-08-09 9:29 ` [alsa-devel] " Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-08-09 9:01 UTC (permalink / raw)
To: perex, tiwai, broonie; +Cc: linux-kernel, alsa-devel, YueHaibing
sound/pci/ac97/ac97_codec.c:599:38: warning:
snd_ac97_controls_master_mono defined but not used [-Wunused-const-variable=]
It is never used, so can be removed.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
sound/pci/ac97/ac97_codec.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/sound/pci/ac97/ac97_codec.c b/sound/pci/ac97/ac97_codec.c
index 96b4601..66f6c3b 100644
--- a/sound/pci/ac97/ac97_codec.c
+++ b/sound/pci/ac97/ac97_codec.c
@@ -596,11 +596,6 @@ static int snd_ac97_put_volsw(struct snd_kcontrol *kcontrol,
return err;
}
-static const struct snd_kcontrol_new snd_ac97_controls_master_mono[2] = {
-AC97_SINGLE("Master Mono Playback Switch", AC97_MASTER_MONO, 15, 1, 1),
-AC97_SINGLE("Master Mono Playback Volume", AC97_MASTER_MONO, 0, 31, 1)
-};
-
static const struct snd_kcontrol_new snd_ac97_controls_tone[2] = {
AC97_SINGLE("Tone Control - Bass", AC97_MASTER_TONE, 8, 15, 1),
AC97_SINGLE("Tone Control - Treble", AC97_MASTER_TONE, 0, 15, 1)
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [alsa-devel] [PATCH -next] ALSA: ac97: remove unused variable 'snd_ac97_controls_master_mono'
2019-08-09 9:01 [PATCH -next] ALSA: ac97: remove unused variable 'snd_ac97_controls_master_mono' YueHaibing
@ 2019-08-09 9:29 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2019-08-09 9:29 UTC (permalink / raw)
To: YueHaibing; +Cc: perex, tiwai, broonie, alsa-devel, linux-kernel
On Fri, 09 Aug 2019 11:01:13 +0200,
YueHaibing wrote:
>
> sound/pci/ac97/ac97_codec.c:599:38: warning:
> snd_ac97_controls_master_mono defined but not used [-Wunused-const-variable=]
>
> It is never used, so can be removed.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-09 9:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-09 9:01 [PATCH -next] ALSA: ac97: remove unused variable 'snd_ac97_controls_master_mono' YueHaibing
2019-08-09 9:29 ` [alsa-devel] " Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®