* [PATCH] ALSA: emux: remove unused redundant variable p2
@ 2017-10-16 11:18 Colin King
2017-10-16 11:38 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-10-16 11:18 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai, alsa-devel; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable p2 is being assigned but never used, it is redundant
and can be safely removed. Cleans up clang warning: Value stored to
'p2' is never read.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
sound/synth/emux/emux_oss.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/synth/emux/emux_oss.c b/sound/synth/emux/emux_oss.c
index de19e108974a..764ff4bc2089 100644
--- a/sound/synth/emux/emux_oss.c
+++ b/sound/synth/emux/emux_oss.c
@@ -430,7 +430,6 @@ gusspec_control(struct snd_emux *emu, struct snd_emux_port *port, int cmd,
{
int voice;
unsigned short p1;
- short p2;
int plong;
struct snd_midi_channel *chan;
@@ -445,7 +444,6 @@ gusspec_control(struct snd_emux *emu, struct snd_emux_port *port, int cmd,
chan = &port->chset.channels[voice];
p1 = *(unsigned short *) &event[4];
- p2 = *(short *) &event[6];
plong = *(int*) &event[4];
switch (cmd) {
--
2.14.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: emux: remove unused redundant variable p2
2017-10-16 11:18 [PATCH] ALSA: emux: remove unused redundant variable p2 Colin King
@ 2017-10-16 11:38 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2017-10-16 11:38 UTC (permalink / raw)
To: Colin King; +Cc: alsa-devel, Jaroslav Kysela, kernel-janitors, linux-kernel
On Mon, 16 Oct 2017 13:18:39 +0200,
Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable p2 is being assigned but never used, it is redundant
> and can be safely removed. Cleans up clang warning: Value stored to
> 'p2' is never read.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-16 11:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-16 11:18 [PATCH] ALSA: emux: remove unused redundant variable p2 Colin King
2017-10-16 11:38 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®