From: Takashi Iwai <tiwai@suse.de>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Cc: "Jaroslav Kysela" <perex@perex.cz>, <alsa-devel@alsa-project.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: atmel: ac97c: fix error return code in atmel_ac97c_probe()
Date: Sat, 01 Jul 2017 08:06:49 +0200 [thread overview]
Message-ID: <s5hmv8o4rnq.wl-tiwai@suse.de> (raw)
In-Reply-To: <20170630223423.GA20635@embeddedgus>
On Sat, 01 Jul 2017 00:34:23 +0200,
Gustavo A. R. Silva wrote:
>
> platform_get_irq() returns an error code, but the ac97c
> driver ignores it and always returns -ENXIO. This is not correct,
> and prevents -EPROBE_DEFER from being propagated properly.
> Notice that platform_get_irq() no longer returns 0 on error.
>
> Print and propagate the return value of platform_get_irq on failure.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Applied, thanks.
Takashi
prev parent reply other threads:[~2017-07-01 6:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 22:34 Gustavo A. R. Silva
2017-07-01 6:06 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hmv8o4rnq.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=garsilva@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome