From: Takashi Iwai <tiwai@suse.de>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: ice1712: wm8766: Remove some unused functions
Date: Sun, 11 Jan 2015 17:04:15 +0100 [thread overview]
Message-ID: <s5hmw5p2tj4.wl-tiwai@suse.de> (raw)
In-Reply-To: <1420990300-19672-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
At Sun, 11 Jan 2015 16:31:40 +0100,
Rickard Strandqvist wrote:
>
> Removes some functions that are not used anywhere:
> snd_wm8766_set_power() snd_wm8766_set_master_mode()
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Applied, thanks.
Takashi
> ---
> sound/pci/ice1712/wm8766.c | 16 ----------------
> sound/pci/ice1712/wm8766.h | 2 --
> 2 files changed, 18 deletions(-)
>
> diff --git a/sound/pci/ice1712/wm8766.c b/sound/pci/ice1712/wm8766.c
> index 21b373b..f7ac8d5 100644
> --- a/sound/pci/ice1712/wm8766.c
> +++ b/sound/pci/ice1712/wm8766.c
> @@ -183,22 +183,6 @@ void snd_wm8766_set_if(struct snd_wm8766 *wm, u16 dac)
> snd_wm8766_write(wm, WM8766_REG_IFCTRL, val | dac);
> }
>
> -void snd_wm8766_set_master_mode(struct snd_wm8766 *wm, u16 mode)
> -{
> - u16 val = wm->regs[WM8766_REG_DACCTRL3] & ~WM8766_DAC3_MSTR_MASK;
> -
> - mode &= WM8766_DAC3_MSTR_MASK;
> - snd_wm8766_write(wm, WM8766_REG_DACCTRL3, val | mode);
> -}
> -
> -void snd_wm8766_set_power(struct snd_wm8766 *wm, u16 power)
> -{
> - u16 val = wm->regs[WM8766_REG_DACCTRL3] & ~WM8766_DAC3_POWER_MASK;
> -
> - power &= WM8766_DAC3_POWER_MASK;
> - snd_wm8766_write(wm, WM8766_REG_DACCTRL3, val | power);
> -}
> -
> void snd_wm8766_volume_restore(struct snd_wm8766 *wm)
> {
> u16 val = wm->regs[WM8766_REG_DACR1];
> diff --git a/sound/pci/ice1712/wm8766.h b/sound/pci/ice1712/wm8766.h
> index c119f84..18c8d9d 100644
> --- a/sound/pci/ice1712/wm8766.h
> +++ b/sound/pci/ice1712/wm8766.h
> @@ -155,8 +155,6 @@ struct snd_wm8766 {
> void snd_wm8766_init(struct snd_wm8766 *wm);
> void snd_wm8766_resume(struct snd_wm8766 *wm);
> void snd_wm8766_set_if(struct snd_wm8766 *wm, u16 dac);
> -void snd_wm8766_set_master_mode(struct snd_wm8766 *wm, u16 mode);
> -void snd_wm8766_set_power(struct snd_wm8766 *wm, u16 power);
> void snd_wm8766_volume_restore(struct snd_wm8766 *wm);
> int snd_wm8766_build_controls(struct snd_wm8766 *wm);
>
> --
> 1.7.10.4
>
prev parent reply other threads:[~2015-01-11 16:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-11 15:31 Rickard Strandqvist
2015-01-11 16:04 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hmw5p2tj4.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®