Re: synaptics touchpad doesn't click

[Takashi Iwai <tiwai@suse.de>]

At Tue, 15 Dec 2009 00:25:18 -0800,
Dmitry Torokhov wrote:
> 
> Indeed, we need to keep the state in synaptics now, thanks for noticing.
> The updated patch is below.

Also, one minor thing I noticed:

> -	if (SYN_CAP_MIDDLE_BUTTON(priv->capabilities)) {
> -		hw->middle = (buf[0] ^ buf[3]) & 0x01;
> -		hw->scroll = hw->w == 2 ? (signed char)buf[1] : 0;
> +		if (click && y < YMIN_NOMINAL) {

In my original patch, the position reporting in the button area is
disabled no matter whether clicked or not.  This was intentional
because I find it quite annoying that the mouse pointer moves slightly
when I click.  I often missed the target when I pressed strongly,
because my finger slipped a millimeter before the click state got
active.

This is a matter of taste, though.


> +			/*
> +			 * User pressed in ClickZone; report new button
> +			 * state but use :w

It's not in "w" field...


thanks,

Takashi