* [PATCH 1/2] ALSA: line6: use msecs_to_jiffies for conversion
@ 2015-02-03 7:38 Nicholas Mc Guire
2015-02-03 9:00 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Nicholas Mc Guire @ 2015-02-03 7:38 UTC (permalink / raw)
To: Jaroslav Kysela
Cc: Takashi Iwai, Greg Kroah-Hartman, Chris Rorvick, Stefan Hajnoczi,
alsa-devel, linux-kernel, Nicholas Mc Guire
This is only an API consolidation and should make things more readable
it replaces var * HZ / 1000 by msecs_to_jiffies(var).
Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
---
Converting milliseconds to jiffies by val * HZ / 1000 is technically
not wrong but msecs_to_jiffies(val) is the cleaner solution and handles
all corner cases correctly. This is a minor API cleanup only.
Patch was only compile tested for x86_64_defconfig + CONFIG_SOUND=y,
CONFIG_SND_USB_POD=m (implies CONFIG_SND_USB_LINE6=y)
Patch is against 3.0.19-rc6 (localversion = -next-20150202)
sound/usb/line6/driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/usb/line6/driver.c b/sound/usb/line6/driver.c
index 2328ec9..3cf12cc 100644
--- a/sound/usb/line6/driver.c
+++ b/sound/usb/line6/driver.c
@@ -166,7 +166,7 @@ void line6_start_timer(struct timer_list *timer, unsigned int msecs,
void (*function)(unsigned long), unsigned long data)
{
setup_timer(timer, function, data);
- mod_timer(timer, jiffies + msecs * HZ / 1000);
+ mod_timer(timer, jiffies + msecs_to_jiffies(msecs));
}
EXPORT_SYMBOL_GPL(line6_start_timer);
--
1.7.10.4
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 1/2] ALSA: line6: use msecs_to_jiffies for conversion
2015-02-03 7:38 [PATCH 1/2] ALSA: line6: use msecs_to_jiffies for conversion Nicholas Mc Guire
@ 2015-02-03 9:00 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2015-02-03 9:00 UTC (permalink / raw)
To: Nicholas Mc Guire
Cc: Jaroslav Kysela, Greg Kroah-Hartman, Chris Rorvick,
Stefan Hajnoczi, alsa-devel, linux-kernel
At Tue, 3 Feb 2015 02:38:39 -0500,
Nicholas Mc Guire wrote:
>
> This is only an API consolidation and should make things more readable
> it replaces var * HZ / 1000 by msecs_to_jiffies(var).
>
>
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> ---
>
> Converting milliseconds to jiffies by val * HZ / 1000 is technically
> not wrong but msecs_to_jiffies(val) is the cleaner solution and handles
> all corner cases correctly. This is a minor API cleanup only.
>
> Patch was only compile tested for x86_64_defconfig + CONFIG_SOUND=y,
> CONFIG_SND_USB_POD=m (implies CONFIG_SND_USB_LINE6=y)
>
> Patch is against 3.0.19-rc6 (localversion = -next-20150202)
Applied, thanks.
Takashi
>
> sound/usb/line6/driver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/usb/line6/driver.c b/sound/usb/line6/driver.c
> index 2328ec9..3cf12cc 100644
> --- a/sound/usb/line6/driver.c
> +++ b/sound/usb/line6/driver.c
> @@ -166,7 +166,7 @@ void line6_start_timer(struct timer_list *timer, unsigned int msecs,
> void (*function)(unsigned long), unsigned long data)
> {
> setup_timer(timer, function, data);
> - mod_timer(timer, jiffies + msecs * HZ / 1000);
> + mod_timer(timer, jiffies + msecs_to_jiffies(msecs));
> }
> EXPORT_SYMBOL_GPL(line6_start_timer);
>
> --
> 1.7.10.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-03 9:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-03 7:38 [PATCH 1/2] ALSA: line6: use msecs_to_jiffies for conversion Nicholas Mc Guire
2015-02-03 9:00 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®