mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: stufever@gmail.com
Cc: linux-kernel@vger.kernel.org, Wang Shaoyan <wangshaoyan.pt@taobao.com>
Subject: Re: [PATCH] ALSA: hda - Add CONFIG_SND_HDA_POWER_SAVE to stac_vrefout_set()
Date: Wed, 10 Aug 2011 11:22:41 +0200	[thread overview]
Message-ID: <s5hobzxboym.wl%tiwai@suse.de> (raw)
In-Reply-To: <1312963264-17192-1-git-send-email-wangshaoyan.pt@taobao.com>

At Wed, 10 Aug 2011 16:01:04 +0800,
stufever@gmail.com wrote:
> 
> From: Wang Shaoyan <wangshaoyan.pt@taobao.com>
> 
> In commit 45eebda7, it add new function stac_vrefout_set, but it
> is only used in code between CONFIG_SND_HDA_POWER_SAVE macro, so
> add the macro to avoid such warning:
> 
>   sound/pci/hda/patch_sigmatel.c:676:12: warning: 'stac_vrefout_set' defined but not used
> 
> Signed-off-by: Wang Shaoyan <wangshaoyan.pt@taobao.com>

Applied now.  Thanks.


Takashi

> ---
>  sound/pci/hda/patch_sigmatel.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
> index aa376b5..5145b66 100644
> --- a/sound/pci/hda/patch_sigmatel.c
> +++ b/sound/pci/hda/patch_sigmatel.c
> @@ -673,6 +673,7 @@ static int stac92xx_smux_enum_put(struct snd_kcontrol *kcontrol,
>  	return 0;
>  }
>  
> +#ifdef CONFIG_SND_HDA_POWER_SAVE
>  static int stac_vrefout_set(struct hda_codec *codec,
>  					hda_nid_t nid, unsigned int new_vref)
>  {
> @@ -696,6 +697,7 @@ static int stac_vrefout_set(struct hda_codec *codec,
>  
>  	return 1;
>  }
> +#endif
>  
>  static unsigned int stac92xx_vref_set(struct hda_codec *codec,
>  					hda_nid_t nid, unsigned int new_vref)
> -- 
> 1.7.4.1
> 

      reply	other threads:[~2011-08-10  9:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-10  8:01 stufever
2011-08-10  9:22 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hobzxboym.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stufever@gmail.com \
    --cc=wangshaoyan.pt@taobao.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®