* [PATCH] ALSA: hda - Add CONFIG_SND_HDA_POWER_SAVE to stac_vrefout_set()
@ 2011-08-10 8:01 stufever
2011-08-10 9:22 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: stufever @ 2011-08-10 8:01 UTC (permalink / raw)
To: linux-kernel; +Cc: tiwai, Wang Shaoyan
From: Wang Shaoyan <wangshaoyan.pt@taobao.com>
In commit 45eebda7, it add new function stac_vrefout_set, but it
is only used in code between CONFIG_SND_HDA_POWER_SAVE macro, so
add the macro to avoid such warning:
sound/pci/hda/patch_sigmatel.c:676:12: warning: 'stac_vrefout_set' defined but not used
Signed-off-by: Wang Shaoyan <wangshaoyan.pt@taobao.com>
---
sound/pci/hda/patch_sigmatel.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
index aa376b5..5145b66 100644
--- a/sound/pci/hda/patch_sigmatel.c
+++ b/sound/pci/hda/patch_sigmatel.c
@@ -673,6 +673,7 @@ static int stac92xx_smux_enum_put(struct snd_kcontrol *kcontrol,
return 0;
}
+#ifdef CONFIG_SND_HDA_POWER_SAVE
static int stac_vrefout_set(struct hda_codec *codec,
hda_nid_t nid, unsigned int new_vref)
{
@@ -696,6 +697,7 @@ static int stac_vrefout_set(struct hda_codec *codec,
return 1;
}
+#endif
static unsigned int stac92xx_vref_set(struct hda_codec *codec,
hda_nid_t nid, unsigned int new_vref)
--
1.7.4.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ALSA: hda - Add CONFIG_SND_HDA_POWER_SAVE to stac_vrefout_set()
2011-08-10 8:01 [PATCH] ALSA: hda - Add CONFIG_SND_HDA_POWER_SAVE to stac_vrefout_set() stufever
@ 2011-08-10 9:22 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2011-08-10 9:22 UTC (permalink / raw)
To: stufever; +Cc: linux-kernel, Wang Shaoyan
At Wed, 10 Aug 2011 16:01:04 +0800,
stufever@gmail.com wrote:
>
> From: Wang Shaoyan <wangshaoyan.pt@taobao.com>
>
> In commit 45eebda7, it add new function stac_vrefout_set, but it
> is only used in code between CONFIG_SND_HDA_POWER_SAVE macro, so
> add the macro to avoid such warning:
>
> sound/pci/hda/patch_sigmatel.c:676:12: warning: 'stac_vrefout_set' defined but not used
>
> Signed-off-by: Wang Shaoyan <wangshaoyan.pt@taobao.com>
Applied now. Thanks.
Takashi
> ---
> sound/pci/hda/patch_sigmatel.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
> index aa376b5..5145b66 100644
> --- a/sound/pci/hda/patch_sigmatel.c
> +++ b/sound/pci/hda/patch_sigmatel.c
> @@ -673,6 +673,7 @@ static int stac92xx_smux_enum_put(struct snd_kcontrol *kcontrol,
> return 0;
> }
>
> +#ifdef CONFIG_SND_HDA_POWER_SAVE
> static int stac_vrefout_set(struct hda_codec *codec,
> hda_nid_t nid, unsigned int new_vref)
> {
> @@ -696,6 +697,7 @@ static int stac_vrefout_set(struct hda_codec *codec,
>
> return 1;
> }
> +#endif
>
> static unsigned int stac92xx_vref_set(struct hda_codec *codec,
> hda_nid_t nid, unsigned int new_vref)
> --
> 1.7.4.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-10 9:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-10 8:01 [PATCH] ALSA: hda - Add CONFIG_SND_HDA_POWER_SAVE to stac_vrefout_set() stufever
2011-08-10 9:22 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®