mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Benjamin Gaignard" <benjamin.gaignard@linaro.org>
Cc: <lgirdwood@gmail.com>, <mcoquelin.stm32@gmail.com>,
	<broonie@kernel.org>, <perex@perex.cz>, <alexandre.torgue@st.com>,
	<arnaud.pouliquen@st.com>, <alsa-devel@alsa-project.org>,
	<linux-arm-kernel@lists.infradead.org>,
	"Benjamin Gaignard" <benjamin.gaignard@st.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sound: stm32: replace "%p" with "%pK"
Date: Fri, 06 Jul 2018 16:59:23 +0200	[thread overview]
Message-ID: <s5hpo00quk4.wl-tiwai@suse.de> (raw)
In-Reply-To: <20180706130703.22352-1-benjamin.gaignard@st.com>

On Fri, 06 Jul 2018 15:07:03 +0200,
Benjamin Gaignard wrote:
> 
> The format specifier "%p" can leak kernel addresses.
> Use "%pK" instead.
> 
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>

The code change itself is OK (apart from the subject prefix to be
"ASoC").  But do we really want to patch manually every single place
like this?  There are thousands of files using '%p'.


thanks,

Takashi

  reply	other threads:[~2018-07-06 14:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-06 13:07 Benjamin Gaignard
2018-07-06 14:59 ` Takashi Iwai [this message]
2018-07-07 11:29   ` Benjamin Gaignard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hpo00quk4.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alexandre.torgue@st.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnaud.pouliquen@st.com \
    --cc=benjamin.gaignard@linaro.org \
    --cc=benjamin.gaignard@st.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®