* [PATCH] sound: stm32: replace "%p" with "%pK"
@ 2018-07-06 13:07 Benjamin Gaignard
2018-07-06 14:59 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: Benjamin Gaignard @ 2018-07-06 13:07 UTC (permalink / raw)
To: lgirdwood, broonie, perex, tiwai, mcoquelin.stm32,
alexandre.torgue, arnaud.pouliquen
Cc: alsa-devel, linux-arm-kernel, linux-kernel, Benjamin Gaignard
The format specifier "%p" can leak kernel addresses.
Use "%pK" instead.
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
---
sound/soc/stm/stm32_adfsdm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/stm/stm32_adfsdm.c b/sound/soc/stm/stm32_adfsdm.c
index db73fef3e500..0e9373064032 100644
--- a/sound/soc/stm/stm32_adfsdm.c
+++ b/sound/soc/stm/stm32_adfsdm.c
@@ -149,7 +149,7 @@ static int stm32_afsdm_pcm_cb(const void *data, size_t size, void *private)
unsigned int old_pos = priv->pos;
unsigned int cur_size = size;
- dev_dbg(rtd->dev, "%s: buff_add :%p, pos = %d, size = %zu\n",
+ dev_dbg(rtd->dev, "%s: buff_add :%pK, pos = %d, size = %zu\n",
__func__, &pcm_buff[priv->pos], priv->pos, size);
if ((priv->pos + size) > buff_size) {
--
2.15.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] sound: stm32: replace "%p" with "%pK"
2018-07-06 13:07 [PATCH] sound: stm32: replace "%p" with "%pK" Benjamin Gaignard
@ 2018-07-06 14:59 ` Takashi Iwai
2018-07-07 11:29 ` Benjamin Gaignard
0 siblings, 1 reply; 3+ messages in thread
From: Takashi Iwai @ 2018-07-06 14:59 UTC (permalink / raw)
To: Benjamin Gaignard
Cc: lgirdwood, mcoquelin.stm32, broonie, perex, alexandre.torgue,
arnaud.pouliquen, alsa-devel, linux-arm-kernel,
Benjamin Gaignard, linux-kernel
On Fri, 06 Jul 2018 15:07:03 +0200,
Benjamin Gaignard wrote:
>
> The format specifier "%p" can leak kernel addresses.
> Use "%pK" instead.
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
The code change itself is OK (apart from the subject prefix to be
"ASoC"). But do we really want to patch manually every single place
like this? There are thousands of files using '%p'.
thanks,
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sound: stm32: replace "%p" with "%pK"
2018-07-06 14:59 ` Takashi Iwai
@ 2018-07-07 11:29 ` Benjamin Gaignard
0 siblings, 0 replies; 3+ messages in thread
From: Benjamin Gaignard @ 2018-07-07 11:29 UTC (permalink / raw)
To: Takashi Iwai
Cc: Liam Girdwood, Maxime Coquelin, Mark Brown, Jaroslav Kysela,
Alexandre Torgue, Arnaud Pouliquen, alsa-devel, Linux ARM,
Benjamin Gaignard, Linux Kernel Mailing List
2018-07-06 16:59 GMT+02:00 Takashi Iwai <tiwai@suse.de>:
> On Fri, 06 Jul 2018 15:07:03 +0200,
> Benjamin Gaignard wrote:
>>
>> The format specifier "%p" can leak kernel addresses.
>> Use "%pK" instead.
>>
>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
>
> The code change itself is OK (apart from the subject prefix to be
> "ASoC"). But do we really want to patch manually every single place
> like this? There are thousands of files using '%p'.
I have limited myself to the few remaining %p in STM32 architecture.
>
>
> thanks,
>
> Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-07 11:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-06 13:07 [PATCH] sound: stm32: replace "%p" with "%pK" Benjamin Gaignard
2018-07-06 14:59 ` Takashi Iwai
2018-07-07 11:29 ` Benjamin Gaignard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®