* [PATCH] sound/sound_core: Fix sparse warnings: returning void-valued expression and make 'soundcore_open' static
@ 2008-11-20 20:25 Hannes Eder
2008-11-21 7:43 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Hannes Eder @ 2008-11-20 20:25 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai, linux-kernel, kernel-janitors
Fix the following sparse warnings:
sound/sound_core.c:460:2: warning: returning void-valued expression
sound/sound_core.c:477:2: warning: returning void-valued expression
sound/sound_core.c:510:5: warning: symbol 'soundcore_open' was not
declared. Should it be static?
Signed-off-by: Hannes Eder <hannes@hanneseder.net>
---
sound/sound_core.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/sound_core.c b/sound/sound_core.c
index a75b289..10ba421 100644
--- a/sound/sound_core.c
+++ b/sound/sound_core.c
@@ -457,7 +457,7 @@ EXPORT_SYMBOL(unregister_sound_mixer);
void unregister_sound_midi(int unit)
{
- return sound_remove_unit(&chains[2], unit);
+ sound_remove_unit(&chains[2], unit);
}
EXPORT_SYMBOL(unregister_sound_midi);
@@ -474,7 +474,7 @@ EXPORT_SYMBOL(unregister_sound_midi);
void unregister_sound_dsp(int unit)
{
- return sound_remove_unit(&chains[3], unit);
+ sound_remove_unit(&chains[3], unit);
}
@@ -507,7 +507,7 @@ static struct sound_unit *__look_for_unit(int
chain, int unit)
return NULL;
}
-int soundcore_open(struct inode *inode, struct file *file)
+static int soundcore_open(struct inode *inode, struct file *file)
{
int chain;
int unit = iminor(inode);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] sound/sound_core: Fix sparse warnings: returning void-valued expression and make 'soundcore_open' static
2008-11-20 20:25 [PATCH] sound/sound_core: Fix sparse warnings: returning void-valued expression and make 'soundcore_open' static Hannes Eder
@ 2008-11-21 7:43 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2008-11-21 7:43 UTC (permalink / raw)
To: Hannes Eder; +Cc: Jaroslav Kysela, linux-kernel, kernel-janitors
At Thu, 20 Nov 2008 21:25:25 +0100,
Hannes Eder wrote:
>
> Fix the following sparse warnings:
>
> sound/sound_core.c:460:2: warning: returning void-valued expression
> sound/sound_core.c:477:2: warning: returning void-valued expression
> sound/sound_core.c:510:5: warning: symbol 'soundcore_open' was not
> declared. Should it be static?
>
> Signed-off-by: Hannes Eder <hannes@hanneseder.net>
Thanks, applied now.
Takashi
> ---
> sound/sound_core.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/sound_core.c b/sound/sound_core.c
> index a75b289..10ba421 100644
> --- a/sound/sound_core.c
> +++ b/sound/sound_core.c
> @@ -457,7 +457,7 @@ EXPORT_SYMBOL(unregister_sound_mixer);
>
> void unregister_sound_midi(int unit)
> {
> - return sound_remove_unit(&chains[2], unit);
> + sound_remove_unit(&chains[2], unit);
> }
>
> EXPORT_SYMBOL(unregister_sound_midi);
> @@ -474,7 +474,7 @@ EXPORT_SYMBOL(unregister_sound_midi);
>
> void unregister_sound_dsp(int unit)
> {
> - return sound_remove_unit(&chains[3], unit);
> + sound_remove_unit(&chains[3], unit);
> }
>
>
> @@ -507,7 +507,7 @@ static struct sound_unit *__look_for_unit(int
> chain, int unit)
> return NULL;
> }
>
> -int soundcore_open(struct inode *inode, struct file *file)
> +static int soundcore_open(struct inode *inode, struct file *file)
> {
> int chain;
> int unit = iminor(inode);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-11-21 7:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-11-20 20:25 [PATCH] sound/sound_core: Fix sparse warnings: returning void-valued expression and make 'soundcore_open' static Hannes Eder
2008-11-21 7:43 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®