mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>,
	Ingo Molnar <mingo@elte.hu>,
	akpm@osdl.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Silly bitmap size accounting fix
Date: Sat, 13 May 2006 17:36:23 +0200	[thread overview]
Message-ID: <s5hpsiivsw8.wl%tiwai@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.58.0605131010110.27003@gandalf.stny.rr.com>

At Sat, 13 May 2006 10:12:11 -0400 (EDT),
Steven Rostedt wrote:
> 
> 
> Index: linux-2.6.17-rc3-mm1/kernel/sched.c
> ===================================================================
> --- linux-2.6.17-rc3-mm1.orig/kernel/sched.c	2006-05-12 04:02:32.000000000 -0400
> +++ linux-2.6.17-rc3-mm1/kernel/sched.c	2006-05-13 10:09:15.000000000 -0400
> @@ -192,6 +192,10 @@ static inline unsigned int task_timeslic
>   * These are the runqueue data structures:
>   */
> 
> +/*
> + * Calculate BITMAP_SIZE.
> + *  The bitmask holds MAX_PRIO bits + 1 for the delimiter.
> + */
>  #define BITMAP_SIZE ((((MAX_PRIO+1+7)/8)+sizeof(long)-1)/sizeof(long))

What's wrong with BITS_TO_LONG(MAX_PRIO + 1) ?

Or, using DECLARE_BITMAP() in struct prio_array would be easier...


Takashi

  parent reply	other threads:[~2006-05-13 15:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-12  8:31 Steven Rostedt
2006-05-12  9:14 ` Ingo Molnar
2006-05-13  1:37   ` Nick Piggin
2006-05-13 14:12     ` Steven Rostedt
2006-05-13 14:38       ` Nick Piggin
2006-05-13 14:53         ` Steven Rostedt
2006-05-13 14:56           ` Nick Piggin
2006-05-13 15:36       ` Takashi Iwai [this message]
2006-05-13 15:45         ` Nick Piggin
2006-05-13 15:59           ` Steven Rostedt
2006-05-14  8:13             ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hpsiivsw8.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=nickpiggin@yahoo.com.au \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®