* [PATCH] ALSA: au88x0: remove redundant assignment of variable i
@ 2017-10-17 11:53 Colin King
2017-10-17 12:16 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-10-17 11:53 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai, Arnd Bergmann, alsa-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The assignment to variable i is redundant as it is never read
because it is updated a little later on. Remove this assignment.
Cleans up clang warning: Value stored to 'i' is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
sound/pci/au88x0/au88x0_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/pci/au88x0/au88x0_core.c b/sound/pci/au88x0/au88x0_core.c
index c308a4f70550..4083c8b01619 100644
--- a/sound/pci/au88x0/au88x0_core.c
+++ b/sound/pci/au88x0/au88x0_core.c
@@ -2628,7 +2628,7 @@ static void vortex_spdif_init(vortex_t * vortex, int spdif_sr, int spdif_mode)
else
edi = 0x1ffff;
} else {
- i = edi = 0x800;
+ edi = 0x800;
}
/* this_04 and this_08 are the CASp4Src's (samplerate converters) */
vortex_src_setupchannel(vortex, this_04, edi, 0, 1,
--
2.14.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: au88x0: remove redundant assignment of variable i
2017-10-17 11:53 [PATCH] ALSA: au88x0: remove redundant assignment of variable i Colin King
@ 2017-10-17 12:16 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2017-10-17 12:16 UTC (permalink / raw)
To: Colin King
Cc: alsa-devel, Arnd Bergmann, Jaroslav Kysela, kernel-janitors,
linux-kernel
On Tue, 17 Oct 2017 13:53:21 +0200,
Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The assignment to variable i is redundant as it is never read
> because it is updated a little later on. Remove this assignment.
> Cleans up clang warning: Value stored to 'i' is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-17 12:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-17 11:53 [PATCH] ALSA: au88x0: remove redundant assignment of variable i Colin King
2017-10-17 12:16 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®