From: Takashi Iwai <tiwai@suse.de>
To: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] AC97: Print AC97 flags in proc file to make debug it easier
Date: Thu, 29 Jan 2009 09:07:09 +0100 [thread overview]
Message-ID: <s5hr62ma636.wl%tiwai@suse.de> (raw)
In-Reply-To: <1233164362-12635-1-git-send-email-cascardo@holoscopio.com>
At Wed, 28 Jan 2009 15:39:22 -0200,
Thadeu Lima de Souza Cascardo wrote:
>
> While debugging some code paths in AC97 codec patches and its suspend
> and resume functions, getting to know the flags has proved useful to
> follow those code paths.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Applied. Thanks.
Takashi
> ---
> sound/pci/ac97/ac97_proc.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/sound/pci/ac97/ac97_proc.c b/sound/pci/ac97/ac97_proc.c
> index 060ea59..73b17d5 100644
> --- a/sound/pci/ac97/ac97_proc.c
> +++ b/sound/pci/ac97/ac97_proc.c
> @@ -125,6 +125,8 @@ static void snd_ac97_proc_read_main(struct snd_ac97 *ac97, struct snd_info_buffe
> snd_iprintf(buffer, "PCI Subsys Device: 0x%04x\n\n",
> ac97->subsystem_device);
>
> + snd_iprintf(buffer, "Flags: %x\n", ac97->flags);
> +
> if ((ac97->ext_id & AC97_EI_REV_MASK) >= AC97_EI_REV_23) {
> val = snd_ac97_read(ac97, AC97_INT_PAGING);
> snd_ac97_update_bits(ac97, AC97_INT_PAGING,
> --
> 1.6.0.6
>
prev parent reply other threads:[~2009-01-29 8:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-28 17:39 Thadeu Lima de Souza Cascardo
2009-01-29 8:07 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hr62ma636.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=cascardo@holoscopio.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®